Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set OwnerReference to sriov-device-plugin configmap #623

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Set OwnerReference to sriov-device-plugin configmap #623

merged 1 commit into from
Feb 8, 2024

Conversation

adrianchiris
Copy link
Collaborator

The configmap is created by the operator but never deleted. Set OwnerReference to SriovOperatorConfig default CR to ensure its deletion.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@adrianchiris
Copy link
Collaborator Author

Related to: #592

@coveralls
Copy link

coveralls commented Feb 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7814500877

  • -6 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 25.856%
Changes Missing Coverage Covered Lines Changed/Added Lines %
controllers/sriovnetworknodepolicy_controller.go 0 6 0.0%
Totals Coverage Status
Change from base Build 7801115751: -0.009%
Covered Lines: 2908
Relevant Lines: 11247
💛 - Coveralls

@adrianchiris adrianchiris mentioned this pull request Feb 6, 2024
Closed
@adrianchiris
Set OwnerReference to sriov-device-plugin configmap
c7aba1e 
The configmap is created by the operator but never deleted.
Set OwnerReference to SriovOperatorConfig default CR to ensure
its deletion.

Signed-off-by: adrianc <adrianc@nvidia.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

zeeke
zeeke approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeeke zeeke merged commit a7d40a7 into k8snetworkplumbingwg:master Feb 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e0ne e0ne e0ne approved these changes

@zeeke zeeke zeeke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrianchiris @coveralls @e0ne @zeeke