Fix network injector webhook #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fix the network injector webhook to stuck the all cluster. k8snetworkplumbingwg#116 move the admission version to v1 In v1 the default `FailurePolicy` is `Fail` and not `Ignore` as v1Beta1 Signed-off-by: Sebastian Sch <sebassch@gmail.com>
|
/lgtm |
|
/lgtm |
|
@SchSeba do we need this change for operator-webhook ? |
|
@zshi-redhat there is no need for the other webhook they should remain on Fail policy as they are only for the sriov CRDs so they will not stuck the system |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fix the network injector webhook to stuck the all cluster.
#116 move the admission version to v1
In v1 the default
FailurePolicyisFailand notIgnoreas v1Beta1Signed-off-by: Sebastian Sch sebassch@gmail.com