Fix sriov functional tests for secure boot env #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedepaol
reviewed
Jun 21, 2021
| for _, itf := range s.Status.Interfaces { | ||
| if itf.Driver == "mlx5_core" { | ||
| if itf.Vendor == mlxVendorID { |
There was a problem hiding this comment.
Why we need this change?
There was a problem hiding this comment.
To support newer card versions that may use a different driver.
Better to go with the vendor ID
test/util/cluster/cluster.go
Outdated
| } | ||
|
|
||
| var runningPod *corev1.Pod | ||
| for retry := 0; retry < 180; retry++ { |
There was a problem hiding this comment.
Can you use the backoff functions here?
| podDefinition = pod.RedefineAsPrivileged(podDefinition) | ||
|
|
||
| volume := corev1.Volume{Name: "host", VolumeSource: corev1.VolumeSource{HostPath: &corev1.HostPathVolumeSource{Path: "/"}}} | ||
| mount := corev1.VolumeMount{Name: "host", MountPath: "/host"} |
There was a problem hiding this comment.
I think the sr-iov daemons already mount /host, would it be better to leverage those?
There was a problem hiding this comment.
The problem is that they are doing chroot /host as part of the code so we can have some flakes if when we exec into the pod it was inside a chroot in another process.
I this is just safer and we are already starting pods as part of the tests so it should not be critical
This commit fix the functional tests when running on a secure boot environment Signed-off-by: Sebastian Sch <sebassch@gmail.com>
SchSeba
force-pushed
the
fix_sriov_secure_boot_tests
branch
from
555288a
to
1843e9b
Compare
|
/lgtm |
|
@mmirecki please take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fix the functional tests when running on a secure boot environment
Signed-off-by: Sebastian Sch sebassch@gmail.com