Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VFs configuration for InfiniBand NICs #275

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Fix VFs configuration for InfiniBand NICs #275

merged 1 commit into from
Apr 13, 2022

Conversation

e0ne
Copy link
Collaborator

@e0ne e0ne commented Apr 1, 2022

Closes: #274

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

SchSeba
SchSeba reviewed Apr 3, 2022
View reviewed changes
pkg/utils/utils.go Outdated
if strings.EqualFold(iface.LinkType, "IB") {
// LinkType is an optional field. Let's fallback to current link type
// if nothing is specified in the SriovNodePolicy
linkType := ifaceStatus.LinkType
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here you want to put the sriov policy?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the pointing me on it. will fix this typo asap.

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@e0ne
Copy link
Collaborator Author

e0ne commented Apr 4, 2022

Go / test (pull_request) failure is not related to this change

@e0ne
Copy link
Collaborator Author

e0ne commented Apr 4, 2022

@pliurh @zshi-redhat could you please run e2e ci?

@e0ne e0ne closed this Apr 6, 2022
@e0ne e0ne reopened this Apr 6, 2022
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@SchSeba
Copy link
Collaborator

SchSeba commented Apr 6, 2022

/lgtm

@github-actions github-actions bot added the lgtm label Apr 6, 2022
@SchSeba
Copy link
Collaborator

SchSeba commented Apr 6, 2022

looks like there is a problem with the controller-gen

@e0ne
Copy link
Collaborator Author

e0ne commented Apr 6, 2022

looks like there is a problem with the controller-gen

Is seems to be a golang issue witch is fixed in pr #277

@adrianchiris
Copy link
Collaborator

/test-all

1 similar comment
@abdallahyas
Copy link
Contributor

/test-all

@e0ne e0ne closed this Apr 13, 2022
@e0ne e0ne reopened this Apr 13, 2022
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@adrianchiris adrianchiris merged commit 236be98 into k8snetworkplumbingwg:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchSeba SchSeba SchSeba left review comments

@adrianchiris adrianchiris adrianchiris approved these changes

Assignees
No one assigned
Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SR-IOV operator fails to configure VFs for InfiniBand Interface
4 participants
@e0ne @SchSeba @adrianchiris @abdallahyas