Add golangci-lint #293

rollandf · 2022-04-28T12:38:38Z

Add golangci.yaml config file
Add Makefile lint target to golangci-lint
Add GitHub action

Related to issue #288

Signed-off-by: Fred Rolland frolland@nvidia.com

github-actions · 2022-04-28T12:38:55Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2022-04-28T12:48:42Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2022-04-28T13:14:48Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2022-04-28T13:21:53Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2022-04-28T13:25:00Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2022-04-28T13:32:19Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2022-05-01T10:19:39Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

.golangci.yml

github-actions · 2022-05-02T08:39:36Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2022-05-08T05:51:53Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2022-05-08T10:05:58Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2022-05-11T07:01:12Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

rollandf · 2022-05-11T07:10:29Z

Commented out currently failing linters.
PRs fixing the issue should uncomment the specific linter fixed.

.github/workflows/go.yml

github-actions · 2022-05-12T20:15:38Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2022-05-17T11:52:10Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2022-05-18T16:12:08Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

rollandf · 2022-05-29T05:16:31Z

@SchSeba @adrianchiris PTAL

adrianchiris

Thanks @rollandf ! LGTM

Makefile

- Add golangci.yaml config file - Add Makefile lint target to golangci-lint - Add GitHub action Related to issue k8snetworkplumbingwg#288 Signed-off-by: Fred Rolland <frolland@nvidia.com>

github-actions · 2022-05-30T10:16:44Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

rollandf · 2022-06-01T08:49:06Z

@zeeke Can you check if any more changes are required?

zeeke · 2022-06-01T09:53:05Z

LGTM

that's great

adrianchiris · 2022-06-01T10:11:32Z

Straightforward change that will improve the projects quality ! thanks @rollandf !

rollandf force-pushed the golangci branch from 2a17c52 to 74d466a Compare April 28, 2022 12:48

rollandf force-pushed the golangci branch from 74d466a to f3bd9e1 Compare April 28, 2022 13:14

rollandf force-pushed the golangci branch from f3bd9e1 to 6ec73c2 Compare April 28, 2022 13:21

rollandf force-pushed the golangci branch from 6ec73c2 to f0c205a Compare April 28, 2022 13:24

rollandf force-pushed the golangci branch from f0c205a to 4d89c2d Compare April 28, 2022 13:32

rollandf force-pushed the golangci branch from 4d89c2d to a5f31f9 Compare May 1, 2022 10:19

rollandf changed the title ~~Add golangci-lint~~ WIP Add golangci-lint May 1, 2022

zeeke reviewed May 2, 2022

View reviewed changes

.golangci.yml Show resolved Hide resolved

rollandf force-pushed the golangci branch from a5f31f9 to 9bf59d6 Compare May 2, 2022 08:39

rollandf force-pushed the golangci branch from 9bf59d6 to 548b2cc Compare May 8, 2022 05:51

rollandf force-pushed the golangci branch from 548b2cc to 8287d15 Compare May 8, 2022 10:05

rollandf force-pushed the golangci branch from 8287d15 to ecaf1c9 Compare May 11, 2022 07:00

rollandf changed the title ~~WIP Add golangci-lint~~ Add golangci-lint May 11, 2022

adrianchiris reviewed May 12, 2022

View reviewed changes

.github/workflows/go.yml Outdated Show resolved Hide resolved

rollandf force-pushed the golangci branch from ecaf1c9 to f64bfe5 Compare May 12, 2022 20:15

rollandf force-pushed the golangci branch from f64bfe5 to 87cfce8 Compare May 17, 2022 11:51

rollandf force-pushed the golangci branch from 87cfce8 to 11990cb Compare May 18, 2022 16:11

adrianchiris approved these changes May 29, 2022

View reviewed changes

zeeke reviewed May 30, 2022

View reviewed changes

Makefile Outdated Show resolved Hide resolved

zeeke reviewed May 30, 2022

View reviewed changes

Makefile Outdated Show resolved Hide resolved

Add golangci-lint

a36b2a7

- Add golangci.yaml config file - Add Makefile lint target to golangci-lint - Add GitHub action Related to issue k8snetworkplumbingwg#288 Signed-off-by: Fred Rolland <frolland@nvidia.com>

rollandf force-pushed the golangci branch from 11990cb to a36b2a7 Compare May 30, 2022 10:16

adrianchiris merged commit abdfe42 into k8snetworkplumbingwg:master Jun 1, 2022

rollandf deleted the golangci branch June 6, 2022 14:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add golangci-lint #293

Add golangci-lint #293

rollandf commented Apr 28, 2022

github-actions bot commented Apr 28, 2022

github-actions bot commented Apr 28, 2022

github-actions bot commented Apr 28, 2022

github-actions bot commented Apr 28, 2022

github-actions bot commented Apr 28, 2022

github-actions bot commented Apr 28, 2022

github-actions bot commented May 1, 2022

github-actions bot commented May 2, 2022

github-actions bot commented May 8, 2022

github-actions bot commented May 8, 2022

github-actions bot commented May 11, 2022

rollandf commented May 11, 2022

github-actions bot commented May 12, 2022

github-actions bot commented May 17, 2022

github-actions bot commented May 18, 2022

rollandf commented May 29, 2022

adrianchiris left a comment

github-actions bot commented May 30, 2022

rollandf commented Jun 1, 2022

zeeke commented Jun 1, 2022

adrianchiris commented Jun 1, 2022

Add golangci-lint #293

Add golangci-lint #293

Conversation

rollandf commented Apr 28, 2022

github-actions bot commented Apr 28, 2022

github-actions bot commented Apr 28, 2022

github-actions bot commented Apr 28, 2022

github-actions bot commented Apr 28, 2022

github-actions bot commented Apr 28, 2022

github-actions bot commented Apr 28, 2022

github-actions bot commented May 1, 2022

github-actions bot commented May 2, 2022

github-actions bot commented May 8, 2022

github-actions bot commented May 8, 2022

github-actions bot commented May 11, 2022

rollandf commented May 11, 2022

github-actions bot commented May 12, 2022

github-actions bot commented May 17, 2022

github-actions bot commented May 18, 2022

rollandf commented May 29, 2022

adrianchiris left a comment

Choose a reason for hiding this comment

github-actions bot commented May 30, 2022

rollandf commented Jun 1, 2022

zeeke commented Jun 1, 2022

adrianchiris commented Jun 1, 2022