-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation for new systemd configuration method #365
Merged
+3,243
−288
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a519556
Add gomock binary download and makefile entry to generate mocks
SchSeba e78cae4
enable CGO
SchSeba e440c7a
Create the new api for ConfigurationMode and update the helper functions
SchSeba f72f2a0
Create the systemd changes for the bindata yaml folder
SchSeba 727022c
Update controllers
SchSeba 2adccca
Update utils and create interface for better unit tests implementation
SchSeba cfb0e3d
switch the bash files implementation with golang configuration
SchSeba 4e0b661
Create the new systemd cmd and implementation changes in the daemon pkg
SchSeba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
bindata/manifests/sriov-config-service/kubernetes/sriov-config-service.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
contents: | | ||
[Unit] | ||
Description=Configures SRIOV NIC | ||
Wants=network-pre.target | ||
Before=network-pre.target | ||
|
||
[Service] | ||
Type=oneshot | ||
ExecStart=/var/lib/sriov/sriov-network-config-daemon service | ||
StandardOutput=journal+console | ||
|
||
[Install] | ||
WantedBy=multi-user.target | ||
enabled: true | ||
name: sriov-config.service | ||
30 changes: 30 additions & 0 deletions
30
bindata/manifests/sriov-config-service/openshift/sriov-config-service.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
apiVersion: machineconfiguration.openshift.io/v1 | ||
kind: MachineConfig | ||
metadata: | ||
labels: | ||
machineconfiguration.openshift.io/role: worker | ||
SchSeba marked this conversation as resolved.
Show resolved
Hide resolved
|
||
name: sriov-config-service | ||
spec: | ||
config: | ||
ignition: | ||
version: 3.2.0 | ||
systemd: | ||
units: | ||
- contents: | | ||
[Unit] | ||
Description=Configures SRIOV NIC | ||
# Removal of this file signals firstboot completion | ||
ConditionPathExists=!/etc/ignition-machine-config-encapsulated.json | ||
# This service is used to configure the SR-IOV VFs on NICs | ||
Wants=network-pre.target | ||
Before=network-pre.target | ||
|
||
[Service] | ||
Type=oneshot | ||
ExecStart=/var/lib/sriov/sriov-network-config-daemon service -v {{ .LogLevel }} | ||
StandardOutput=journal+console | ||
|
||
[Install] | ||
WantedBy=multi-user.target | ||
enabled: true | ||
name: "sriov-config.service" |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just thinking out loud, would we want to add templatisation for dependent services? Is it possible that some users may want to add services in the
After=
field based on their host OS setup?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a great Idea the question is how we will expose that template to the user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we definately need to have this configurable. Let's think about thi in a follow-up PR