Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "support graceful node shutdown" #374

Merged
merged 1 commit into from
Nov 6, 2022

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Nov 2, 2022

I will like to propose the revert of this PR.

This PR was intended to switch the machine config operator pause mechanism we have in place for openshift.
The problem is the feature is not fully integrated into openshift yet so merging this PR re-introduce the race conditions we had before in openshift between the sriov operator and the machine config operator.

Reverts #363

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@SchSeba
Copy link
Collaborator Author

SchSeba commented Nov 2, 2022

/cc @bn222 @e0ne @zshi-redhat

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3377803353

  • 3 of 130 (2.31%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.4%) to 25.23%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/daemon/daemon.go 3 130 2.31%
Files with Coverage Reduction New Missed Lines %
pkg/daemon/daemon.go 1 41.75%
controllers/sriovnetwork_controller.go 2 67.0%
api/v1/helper.go 3 41.2%
Totals Coverage Status
Change from base Build 3339373925: -0.4%
Covered Lines: 1890
Relevant Lines: 7491

💛 - Coveralls

@adrianchiris
Copy link
Collaborator

/test-all

@zshi-redhat
Copy link
Collaborator

/lgtm

@bn222
Copy link
Collaborator

bn222 commented Nov 3, 2022

/lgtm

@github-actions github-actions bot added the lgtm label Nov 3, 2022
@SchSeba
Copy link
Collaborator Author

SchSeba commented Nov 6, 2022

two maintainers from two different companies approve the change merging

@SchSeba SchSeba merged commit eaaa113 into master Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants