Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass ctx param in controller methods #392

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

tariq1890
Copy link
Contributor

The Reconcile method already has ctx in its method signature. It's best practice to pass the same ctx object down the controller method call stack

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@tariq1890
Copy link
Contributor Author

/test-all

1 similar comment
@adrianchiris
Copy link
Collaborator

/test-all

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3743388413

  • 39 of 94 (41.49%) changed or added relevant lines in 5 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 25.489%

Changes Missing Coverage Covered Lines Changed/Added Lines %
controllers/sriovibnetwork_controller.go 8 9 88.89%
controllers/sriovnetwork_controller.go 7 8 87.5%
controllers/sriovoperatorconfig_controller.go 17 20 85.0%
controllers/sriovnetworkpoolconfig_controller.go 7 11 63.64%
controllers/sriovnetworknodepolicy_controller.go 0 46 0.0%
Files with Coverage Reduction New Missed Lines %
controllers/sriovnetwork_controller.go 2 69.0%
api/v1/helper.go 3 41.2%
Totals Coverage Status
Change from base Build 3739694028: 0.1%
Covered Lines: 1914
Relevant Lines: 7509

💛 - Coveralls

@tariq1890
Copy link
Contributor Author

@adrianchiris can we merge this?

@adrianchiris
Copy link
Collaborator

@tariq1890 the review process requires approval of two maintainers from two different companies.

@tariq1890
Copy link
Contributor Author

tariq1890 commented Dec 27, 2022

Thanks @adrianchiris !

@SchSeba @pliurh Requesting your reviews

@tariq1890
Copy link
Contributor Author

Friendly ping

@tariq1890
Copy link
Contributor Author

??? @SchSeba @pliurh

Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@adrianchiris adrianchiris merged commit 8f5bcbb into k8snetworkplumbingwg:master Jan 15, 2023
@tariq1890 tariq1890 deleted the pass-ctx branch January 16, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants