Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy default SriovNetworkNodePolicy by helm chart #401

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Deploy default SriovNetworkNodePolicy by helm chart #401

merged 1 commit into from
Feb 22, 2023

Conversation

e0ne
Copy link
Collaborator

@e0ne e0ne commented Jan 24, 2023

The owner of SR-IOV Device Plugin daemonset is default policy so it will be deleted both with a defaut during helm uninstall procedure.

Relates-Bug: #385

Signed-off-by: Ivan Kolodiazhnyi ikolodiazhny@nvidia.com

@e0ne
Deploy default SriovNetworkNodePolicy by helm chart
c2ee9da 
The owner of SR-IOV Device Plugin daemonset is default policy
so it will be deleted both with a defaut during helm uninstall
procedure.

Relates-Bug: k8snetworkplumbingwg#385

Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3999803947

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 25.263%
Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 67.33%
Totals Coverage Status
Change from base Build 3993689913: -0.03%
Covered Lines: 1897
Relevant Lines: 7509
💛 - Coveralls

@e0ne e0ne mentioned this pull request Jan 25, 2023
Merged
adrianchiris
adrianchiris approved these changes Feb 15, 2023
View reviewed changes
Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianchiris
Copy link
Collaborator

@SchSeba PTAL

SchSeba
SchSeba approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@SchSeba SchSeba merged commit 331d1ae into k8snetworkplumbingwg:master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchSeba SchSeba SchSeba approved these changes

@adrianchiris adrianchiris adrianchiris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@e0ne @coveralls @adrianchiris @SchSeba