Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix networks-status annotation in e2e tests #413

Merged

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Mar 6, 2023

Annotation k8s.v1.cni.cncf.io/networks-status has been changed to k8s.v1.cni.cncf.io/network-status and the former is no longer supported. Use the new key in e2e tests utilities.

Refs:

Annotation `k8s.v1.cni.cncf.io/networks-status` has been changed
to `k8s.v1.cni.cncf.io/network-status` and the former is no longer
supported. Use the new key in e2e tests utilities.

Refs:
k8snetworkplumbingwg/network-attachment-definition-client/pull/45

Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4341504219

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.09%) to 25.674%

Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 65.35%
controllers/sriovnetwork_controller.go 2 69.0%
api/v1/helper.go 3 41.92%
Totals Coverage Status
Change from base Build 4301504699: -0.09%
Covered Lines: 1942
Relevant Lines: 7564

💛 - Coveralls

Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adrianchiris adrianchiris merged commit 8c3bf58 into k8snetworkplumbingwg:master Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants