virtual cluster e2e tests changes #462

SchSeba · 2023-06-20T12:26:01Z

Initial work to be able to run our conformance tests on a virtual cluster

Run output

=== RUN   TestTest
Running Suite: SRIOV Operator conformance tests - /home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance
=====================================================================================================================================================================
Random Seed: 1687262298

Will run 27 of 27 specs
------------------------------
[BeforeSuite] 
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/test_suite_test.go:80
[BeforeSuite] PASSED [0.308 seconds]
------------------------------
[sriov] operator No SriovNetworkNodePolicy SR-IOV network config daemon can be set by nodeselector Should schedule the config daemon on selected nodes
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:109
Waiting for the sriov state to stable
Sriov state is stable
  STEP: Checking that a daemon is scheduled on each worker node @ 06/20/23 14:58:33.937
  STEP: Labeling one worker node with the label needed for the daemon @ 06/20/23 14:58:34.098
  STEP: Setting the node selector for each daemon @ 06/20/23 14:58:34.276
  STEP: Checking that a daemon is scheduled only on selected node @ 06/20/23 14:58:34.392
  STEP: Restoring the node selector for daemons @ 06/20/23 14:58:36.228
  STEP: Checking that a daemon is scheduled on each worker node @ 06/20/23 14:58:36.38
• [17.335 seconds]
------------------------------
[sriov] operator Generic SriovNetworkNodePolicy Resource Injector Should inject downward api volume with no labels present
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:225
Waiting for the sriov state to stable
Sriov state is stable
• [72.291 seconds]
------------------------------
[sriov] operator Generic SriovNetworkNodePolicy Resource Injector Should inject downward api volume with labels present
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:287
• [2.479 seconds]
------------------------------
[sriov] operator Generic SriovNetworkNodePolicy VF flags Should configure the spoofChk boolean variable
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:424
  STEP: configuring spoofChk on @ 06/20/23 14:59:53.829
  STEP: removing sriov network @ 06/20/23 14:59:56.184
  STEP: configuring spoofChk off @ 06/20/23 14:59:56.305
• [8.653 seconds]
------------------------------
[sriov] operator Generic SriovNetworkNodePolicy VF flags Should configure the trust boolean variable
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:469
  STEP: configuring trust on @ 06/20/23 15:00:01.387
  STEP: removing sriov network @ 06/20/23 15:00:04.896
  STEP: configuring trust off @ 06/20/23 15:00:05.011
• [7.432 seconds]
------------------------------
[sriov] operator Generic SriovNetworkNodePolicy VF flags Should configure the the link state variable
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:513
  [SKIPPED] in [It] - /home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:516 @ 06/20/23 15:00:09.867
S [SKIPPED] [2.531 seconds]
[sriov] operator Generic SriovNetworkNodePolicy VF flags [It] Should configure the the link state variable
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:513

  [SKIPPED] Bug in IGB driver
  In [It] at: /home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:516 @ 06/20/23 15:00:09.867
------------------------------
[sriov] operator Generic SriovNetworkNodePolicy VF flags rate limit Should configure the requested rate limit flags under the vf
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:582
  [SKIPPED] in [It] - /home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:588 @ 06/20/23 15:00:12.198
S [SKIPPED] [2.331 seconds]
[sriov] operator Generic SriovNetworkNodePolicy VF flags rate limit [It] Should configure the requested rate limit flags under the vf
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:582

  [SKIPPED] Skip rate limit test no mellanox driver found
  In [It] at: /home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:588 @ 06/20/23 15:00:12.198
------------------------------
[sriov] operator Generic SriovNetworkNodePolicy VF flags vlan and Qos vlan Should configure the requested vlan and Qos vlan flags under the vf
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:628
• [4.808 seconds]
------------------------------
[sriov] operator Generic SriovNetworkNodePolicy Multiple sriov device and attachment Should configure multiple network attachments
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:665
• [3.531 seconds]
------------------------------
[sriov] operator Generic SriovNetworkNodePolicy IPv6 configured secondary interfaces on pods should be able to ping each other
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:683
• [14.095 seconds]
------------------------------
[sriov] operator Generic SriovNetworkNodePolicy NAD update NAD is updated when SriovNetwork spec/networkNamespace is changed
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:706
• [18.655 seconds]
------------------------------
[sriov] operator Generic SriovNetworkNodePolicy NAD update NAD default gateway is updated when SriovNetwork ipam is changed
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:744
• [0.595 seconds]
------------------------------
[sriov] operator Generic SriovNetworkNodePolicy SRIOV and macvlan Should be able to create a pod with both sriov and macvlan interfaces
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:780
• [2.532 seconds]
------------------------------
[sriov] operator Generic SriovNetworkNodePolicy Meta Plugin Configuration Should be able to configure a metaplugin
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:820
• [2.832 seconds]
------------------------------
[sriov] operator Generic SriovNetworkNodePolicy Virtual Functions should release the VFs once the pod deleted and same VFs can be used by the new created pods
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:842
  STEP: Create first Pod which consumes all available VFs @ 06/20/23 15:00:59.495
  STEP: Checking that first Pod is in Running state @ 06/20/23 15:00:59.688
  STEP: Create second Pod which consumes one more VF @ 06/20/23 15:01:10.378
  STEP: Checking second that pod is in Pending state @ 06/20/23 15:01:10.504
  STEP: Checking that relevant error event was originated @ 06/20/23 15:01:10.566
  STEP: Delete first pod and release all VFs @ 06/20/23 15:01:10.639
  STEP: Checking that second pod is able to use released VF @ 06/20/23 15:01:10.694
• [16.768 seconds]
------------------------------
[sriov] operator Custom SriovNetworkNodePolicy Configuration Create vfio-pci node policy Should be possible to create a vfio-pci resource
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:939
Waiting for the sriov state to stable
Sriov state is stable
  STEP: creating a vfio-pci node policy @ 06/20/23 15:02:11.355
  STEP: waiting for the node state to be updated @ 06/20/23 15:02:11.455
  STEP: waiting the sriov to be stable on the node @ 06/20/23 15:02:11.473
Waiting for the sriov state to stable
Sriov state is stable
  STEP: waiting for the resources to be available @ 06/20/23 15:03:11.262
• [115.318 seconds]
------------------------------
[sriov] operator Custom SriovNetworkNodePolicy Configuration PF Partitioning Should be possible to partition the pf's vfs
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:982
Waiting for the sriov state to stable
Sriov state is stable
Waiting for the sriov state to stable
Sriov state is stable
• [182.820 seconds]
------------------------------
[sriov] operator Custom SriovNetworkNodePolicy Configuration PF Partitioning Should not be possible to have overlapping pf ranges
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1073
Waiting for the sriov state to stable
Sriov state is stable
• [64.747 seconds]
------------------------------
[sriov] operator Custom SriovNetworkNodePolicy Configuration Main PF should work when vfs are used by pods
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1138
Waiting for the sriov state to stable
Sriov state is stable
  [SKIPPED] in [It] - /home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1147 @ 06/20/23 15:07:38.492
S [SKIPPED] [19.590 seconds]
[sriov] operator Custom SriovNetworkNodePolicy Configuration Main PF [It] should work when vfs are used by pods
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1138

  [SKIPPED] Could not find pf used as gateway
  In [It] at: /home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1147 @ 06/20/23 15:07:38.492
------------------------------
[sriov] operator Custom SriovNetworkNodePolicy Configuration PF shutdown Should be able to create pods successfully if PF is down.Pods are able to communicate with each other on the same node
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1168
Waiting for the sriov state to stable
Sriov state is stable
  [SKIPPED] in [It] - /home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1171 @ 06/20/23 15:07:48.948
S [SKIPPED] [10.456 seconds]
[sriov] operator Custom SriovNetworkNodePolicy Configuration PF shutdown [It] Should be able to create pods successfully if PF is down.Pods are able to communicate with each other on the same node
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1168

  [SKIPPED] Bug in IGB driver
  In [It] at: /home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1171 @ 06/20/23 15:07:48.948
------------------------------
[sriov] operator Custom SriovNetworkNodePolicy Configuration MTU Should support jumbo frames
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1342
Waiting for the sriov state to stable
Sriov state is stable
  [SKIPPED] in [BeforeEach] - /home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1225 @ 06/20/23 15:07:59.212
S [SKIPPED] [10.263 seconds]
[sriov] operator Custom SriovNetworkNodePolicy Configuration MTU [BeforeEach] Should support jumbo frames
  [BeforeEach] /home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1222
  [It] /home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1342

  [SKIPPED] Bug in IGB driver
  In [BeforeEach] at: /home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1225 @ 06/20/23 15:07:59.212
------------------------------
[sriov] operator Custom SriovNetworkNodePolicy Nic Validation Test connectivity using the requested nic Intel Corporation Ethernet Controller XXV710 for 25GbE SFP28
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1486
Waiting for the sriov state to stable
Sriov state is stable
  STEP: searching for the requested network card @ 06/20/23 15:08:09.535
  [SKIPPED] in [It] - /home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1413 @ 06/20/23 15:08:09.536
S [SKIPPED] [10.324 seconds]
[sriov] operator Custom SriovNetworkNodePolicy Nic Validation Test connectivity using the requested nic [It] Intel Corporation Ethernet Controller XXV710 for 25GbE SFP28
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1486

  [SKIPPED] skip nic validate as wasn't able to find a nic with vendorID 8086 and deviceID 158b
  In [It] at: /home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1413 @ 06/20/23 15:08:09.536
------------------------------
[sriov] operator Custom SriovNetworkNodePolicy Nic Validation Test connectivity using the requested nic Ethernet Controller XXV710 Intel(R) FPGA Programmable Acceleration Card N3000 for Networking
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1487
Waiting for the sriov state to stable
Sriov state is stable
  STEP: searching for the requested network card @ 06/20/23 15:08:19.948
  [SKIPPED] in [It] - /home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1413 @ 06/20/23 15:08:19.949
S [SKIPPED] [10.413 seconds]
[sriov] operator Custom SriovNetworkNodePolicy Nic Validation Test connectivity using the requested nic [It] Ethernet Controller XXV710 Intel(R) FPGA Programmable Acceleration Card N3000 for Networking
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1487

  [SKIPPED] skip nic validate as wasn't able to find a nic with vendorID 8086 and deviceID 0d58
  In [It] at: /home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1413 @ 06/20/23 15:08:19.949
------------------------------
[sriov] operator Custom SriovNetworkNodePolicy Resource Injector SR-IOV Operator Config, disable Resource Injector
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1504
Waiting for the sriov state to stable
Sriov state is stable
• [31.044 seconds]
------------------------------
[sriov] operator Custom SriovNetworkNodePolicy Resource Injector SR-IOV Operator Config, disable Operator Webhook
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1525
Waiting for the sriov state to stable
Sriov state is stable
• [30.862 seconds]
------------------------------
[sriov] operator Custom SriovNetworkNodePolicy Resource Injector SR-IOV Operator Config, disable Resource Injector and Operator Webhook
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1545
Waiting for the sriov state to stable
Sriov state is stable
• [41.146 seconds]
------------------------------
[sriov] operator Custom SriovNetworkNodePolicy vhost-net and tun devices Validation Should have the vhost-net device inside the container
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1661
Waiting for the sriov state to stable
Sriov state is stable
Waiting for the sriov state to stable
Sriov state is stable
  STEP: waiting for the resources to be available @ 06/20/23 15:11:12.666
  STEP: creating a pod @ 06/20/23 15:11:21.314
  STEP: checking the /dev/vhost device exist inside the container @ 06/20/23 15:11:22.491
  STEP: checking the /dev/vhost device exist inside the container @ 06/20/23 15:11:22.791
  STEP: creating a tap device inside the container @ 06/20/23 15:11:23.135
  STEP: checking the tap device was created inside the container @ 06/20/23 15:11:23.447
• [80.842 seconds]
------------------------------
[AfterSuite] 
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/test_suite_test.go:85
[AfterSuite] PASSED [8.489 seconds]
------------------------------
[ReportAfterSuite] conformance
/home/sscheink/Documents/GolangProjects/src/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/test_suite_test.go:59
[ReportAfterSuite] PASSED [0.000 seconds]
------------------------------

Ran 20 of 27 Specs in 793.499 seconds
SUCCESS! -- 20 Passed | 0 Failed | 0 Pending | 7 Skipped
--- PASS: TestTest (793.65s)
PASS

github-actions · 2023-06-20T12:26:12Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls · 2023-06-20T12:34:04Z

Pull Request Test Coverage Report for Build 6328795228

0 of 0 changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 25.774%

Files with Coverage Reduction	New Missed Lines	%
controllers/sriovnetworkpoolconfig_controller.go	4	53.03%

Totals
Change from base Build 6237323479:	-0.02%
Covered Lines:	2165
Relevant Lines:	8400

💛 - Coveralls

doc/testing-virtual-machine.md

zeeke · 2023-06-21T06:49:18Z

doc/testing-virtual-machine.md

+Second step is to add the intel virtual nic to the supported nics configmap.
+
+```
+Intel_ixgbe_82576: 8086 10c9 10ca


Can we permanently add this NIC to the config-map? What are the drawbacks?

for example right now there are the two bugs on the nic so I will not like to add a nic that doesn't pass our tests.
maybe after the kernel fix the driver we can think on adding the nic, and asking Intel if they are fine supporting it :)

/cc @Eoghan1232

github-actions · 2023-06-21T08:00:06Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke

LGTM

adrianchiris · 2023-07-04T08:28:13Z

doc/testing-virtual-machine.md

+WantedBy=network-online.target
+```
+
+# TBD


nit: we need this TBD ?

adrianchiris · 2023-07-04T08:31:10Z

test/util/network/network.go

@@ -37,6 +38,10 @@ func CreateSriovNetwork(clientSet *testclient.ClientSet, intf *sriovv1.Interface
 			LinkState: "enable",
 		}}

+	if cluster.VirtualCluster() {
+		sriovNetwork.Spec.LinkState = ""


not working with emulated intel nic ?

right the driver doesn't support it.

adrianchiris · 2023-07-04T08:35:14Z

test/conformance/tests/test_sriov_operator.go

@@ -511,6 +511,11 @@ var _ = Describe("[sriov] operator", func() {

 			// 25961
 			It("Should configure the the link state variable", func() {
+				if cluster.VirtualCluster() {
+					// https://bugzilla.redhat.com/show_bug.cgi?id=2214976


can u make those bugs public ? i dont have access to them.

github-actions · 2023-09-10T10:48:35Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-09-10T11:14:58Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-09-10T11:16:18Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-09-10T11:35:05Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-09-10T11:57:11Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-09-10T13:55:56Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-09-10T14:03:56Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-09-10T14:06:00Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-09-10T15:26:51Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-09-10T15:53:21Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-09-12T10:15:40Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke

Left few comments. This PR will boost our review process, great work!

zeeke · 2023-09-15T15:12:51Z

hack/test.sh

can you remove this file?

test/conformance/tests/init.go

test/util/cluster/cluster.go

hack/run-e2e-conformance-virtual-cluster.sh

github-actions · 2023-09-21T17:03:46Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-09-21T17:07:27Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-09-21T17:56:15Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-09-21T17:57:50Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

.github/workflows/virtual-cluster.yml

github-actions · 2023-09-26T12:37:27Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-09-26T13:09:51Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-09-26T13:47:10Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-09-26T14:53:21Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

SchSeba · 2023-09-26T17:04:09Z

Hi @zeeke @e0ne can you please take a look we have green lanes! both OCP and vanilla k8s

zeeke

LGTM

e0ne · 2023-09-27T10:39:42Z

hack/run-e2e-conformance-virtual-ocp.sh

+cluster_name=${CLUSTER_NAME:-ocp-virt}
+domain_name=lab
+
+api_ip=${API_IP:-192.168.122.253}


AFAIR, 192.168.122.0/24 a default libvirt network. will it work if this network isn't created? IMO, it's better to create a separate network

e0ne · 2023-09-27T10:41:58Z

hack/run-e2e-conformance-virtual-ocp.sh

+  trap cleanup EXIT
+fi
+
+kcli create network -c 192.168.${virtual_router_id}.0/24 --nodhcp -i $cluster_name


How will it work with defined $api_ip?

that is fine because the igb device is connected to an isolated network and the API is connected to a NAT network

e0ne · 2023-09-27T10:42:53Z

hack/run-e2e-conformance-virtual-ocp.sh

+export ENABLE_ADMISSION_CONTROLLER=true
+export SKIP_VAR_SET=""
+export NAMESPACE="openshift-sriov-network-operator"
+export OPERATOR_NAMESPACE="openshift-sriov-network-operator"


nit: OPERATOR_NAMESPACE=$NAMESPACE

github-actions · 2023-09-27T15:18:08Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

Signed-off-by: Sebastian Sch <sebassch@gmail.com>

github-actions · 2023-09-27T16:31:07Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

e0ne

Thanks for addressing my comments, @SchSeba

zeeke reviewed Jun 21, 2023

View reviewed changes

SchSeba force-pushed the support_virtual_cluster branch from 34e20d4 to 56165c6 Compare June 21, 2023 07:59

zeeke approved these changes Jun 28, 2023

View reviewed changes

adrianchiris reviewed Jul 4, 2023

View reviewed changes

doc/testing-virtual-machine.md Outdated

WantedBy=network-online.target

```

# TBD

Copy link

Collaborator

adrianchiris Jul 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we need this TBD ?

adrianchiris reviewed Jul 4, 2023

View reviewed changes

SchSeba force-pushed the support_virtual_cluster branch from 56165c6 to f24a8cb Compare September 10, 2023 10:48

SchSeba force-pushed the support_virtual_cluster branch from f24a8cb to f53c1ac Compare September 10, 2023 11:14

SchSeba force-pushed the support_virtual_cluster branch from f53c1ac to f581586 Compare September 10, 2023 11:16

SchSeba force-pushed the support_virtual_cluster branch from f581586 to 270b434 Compare September 10, 2023 11:34

SchSeba force-pushed the support_virtual_cluster branch from 270b434 to ebb3e9f Compare September 10, 2023 11:57

SchSeba force-pushed the support_virtual_cluster branch from ebb3e9f to f664ae1 Compare September 10, 2023 13:55

SchSeba force-pushed the support_virtual_cluster branch from f664ae1 to 439db4f Compare September 10, 2023 14:03

SchSeba force-pushed the support_virtual_cluster branch from 439db4f to da29355 Compare September 10, 2023 14:05

SchSeba force-pushed the support_virtual_cluster branch from da29355 to f96af39 Compare September 10, 2023 15:26

SchSeba force-pushed the support_virtual_cluster branch from f96af39 to db23ea3 Compare September 10, 2023 15:53

SchSeba force-pushed the support_virtual_cluster branch from db23ea3 to ef36f8f Compare September 10, 2023 16:37

SchSeba force-pushed the support_virtual_cluster branch from ea5971f to bff8985 Compare September 12, 2023 10:15

zeeke reviewed Sep 15, 2023

View reviewed changes

SchSeba force-pushed the support_virtual_cluster branch from bff8985 to aecf9fd Compare September 21, 2023 17:03

SchSeba force-pushed the support_virtual_cluster branch from aecf9fd to fb0b85e Compare September 21, 2023 17:07

SchSeba force-pushed the support_virtual_cluster branch from fb0b85e to c8fe268 Compare September 21, 2023 17:56

SchSeba force-pushed the support_virtual_cluster branch from c8fe268 to d78b789 Compare September 21, 2023 17:57

zeeke reviewed Sep 22, 2023

View reviewed changes

.github/workflows/virtual-cluster.yml Outdated Show resolved Hide resolved

SchSeba force-pushed the support_virtual_cluster branch from d78b789 to 30b9bbc Compare September 26, 2023 12:37

SchSeba force-pushed the support_virtual_cluster branch from 30b9bbc to fcc605a Compare September 26, 2023 13:09

SchSeba force-pushed the support_virtual_cluster branch from fcc605a to 404ca97 Compare September 26, 2023 13:46

SchSeba force-pushed the support_virtual_cluster branch from 404ca97 to f53b66c Compare September 26, 2023 14:53

zeeke approved these changes Sep 27, 2023

View reviewed changes

e0ne reviewed Sep 27, 2023

View reviewed changes

SchSeba force-pushed the support_virtual_cluster branch from f53b66c to 41aaca7 Compare September 27, 2023 15:17

virtual cluster e2e tests changes

2c5fc1b

Signed-off-by: Sebastian Sch <sebassch@gmail.com>

SchSeba force-pushed the support_virtual_cluster branch from 41aaca7 to 2c5fc1b Compare September 27, 2023 16:30

e0ne approved these changes Sep 28, 2023

View reviewed changes

e0ne merged commit 22c7a2e into k8snetworkplumbingwg:master Sep 28, 2023
10 of 11 checks passed

virtual cluster e2e tests changes #462

virtual cluster e2e tests changes #462

Conversation

SchSeba commented Jun 20, 2023 • edited Loading

github-actions bot commented Jun 20, 2023

coveralls commented Jun 20, 2023 • edited Loading

Pull Request Test Coverage Report for Build 6328795228

💛 - Coveralls

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jun 21, 2023

zeeke left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 10, 2023

github-actions bot commented Sep 10, 2023

github-actions bot commented Sep 10, 2023

github-actions bot commented Sep 10, 2023

github-actions bot commented Sep 10, 2023

github-actions bot commented Sep 10, 2023

github-actions bot commented Sep 10, 2023

github-actions bot commented Sep 10, 2023

github-actions bot commented Sep 10, 2023

github-actions bot commented Sep 10, 2023

github-actions bot commented Sep 12, 2023

zeeke left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 26, 2023

github-actions bot commented Sep 26, 2023

github-actions bot commented Sep 26, 2023

github-actions bot commented Sep 26, 2023

SchSeba commented Sep 26, 2023

zeeke left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 27, 2023

github-actions bot commented Sep 27, 2023

e0ne left a comment

Choose a reason for hiding this comment

SchSeba commented Jun 20, 2023 •

edited

Loading

coveralls commented Jun 20, 2023 •

edited

Loading