Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of ioutil deprecated functions #491

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Remove use of ioutil deprecated functions #491

merged 1 commit into from
Aug 21, 2023

Conversation

adrianchiris
Copy link
Collaborator

use equivalent functions from os and io package

no more strikethrough lines in your IDE for deprecated functions ! 💪

@adrianchiris
Remove use of ioutil deprecated functions
edf7474 
use equivalent functions from os and io package

Signed-off-by: adrianc <adrianc@nvidia.com>
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

Eoghan1232
Eoghan1232 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@Eoghan1232 Eoghan1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM!

The error from CodeQL doesn't have anything to do with PR IMO, so I am okay to merge this, and a follow up PR can be done to fix that issue.
Unless you want to do a quick fix for it.

zeeke
zeeke approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Agree with @Eoghan1232

@zeeke zeeke merged commit db75a90 into k8snetworkplumbingwg:master Aug 21, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeeke zeeke zeeke approved these changes

@Eoghan1232 Eoghan1232 Eoghan1232 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrianchiris @zeeke @Eoghan1232