Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vlanProto parameter #517

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Add vlanProto parameter #517

merged 1 commit into from
Oct 12, 2023

Conversation

mlguerrero12
Copy link
Contributor

The sriov-cni has a new parameter to set the vlan protocol assign to the vf.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6431474589

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 25.068%
Files with Coverage Reduction New Missed Lines %
controllers/sriovnetwork_controller.go 2 71.32%
Totals Coverage Status
Change from base Build 6418477426: 0.02%
Covered Lines: 2226
Relevant Lines: 8880
💛 - Coveralls

zeeke
zeeke approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It looks like failing github actions are not related to this PR, as they fail in other PRs as well

@mlguerrero12
Copy link
Contributor Author

yes, we need to merge the fix in sriov-cni

@mlguerrero12 mlguerrero12 reopened this Oct 9, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@mlguerrero12
Copy link
Contributor Author

@adrianchiris, @SchSeba, could you please have a look at this? It's for the recently added vlanProto parameter. Thanks.

@mlguerrero12
Add vlanProto parameter
bcfa74a 
The sriov-cni has a new parameter to set the vlan protocol
assign to the vf.

Signed-off-by: Marcelo Guerrero <marguerr@redhat.com>
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@mlguerrero12
Copy link
Contributor Author

@Eoghan1232, could you please have a look at this? It's for the recent vlanProto parameter we added in sriov-cni. Thanks.

Eoghan1232
Eoghan1232 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@Eoghan1232 Eoghan1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eoghan1232
Copy link
Collaborator

merging with 2 approvals.

@Eoghan1232 Eoghan1232 merged commit 314f246 into k8snetworkplumbingwg:master Oct 12, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeeke zeeke zeeke approved these changes

@Eoghan1232 Eoghan1232 Eoghan1232 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mlguerrero12 @coveralls @Eoghan1232 @zeeke