CI scripts improvements #523

SchSeba · 2023-10-18T22:08:04Z

Updates to OCP:

add a retry to the policy create to fix OCP CI flake
add more ram to the OCP master single node
add a wait for registry to be available
update the ocp version to latest 4.14 rc release

Updates for K8s:

switch to not use dockerhub for the registry image to overcome the pull limit

github actions:

always remove the cluster

Signed-off-by: Sebastian Sch sebassch@gmail.com

github-actions · 2023-10-18T22:08:18Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls · 2023-10-18T22:16:09Z

Pull Request Test Coverage Report for Build 6602752479

0 of 0 changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 25.589%

Files with Coverage Reduction	New Missed Lines	%
api/v1/helper.go	3	42.04%

Totals
Change from base Build 6597902850:	0.02%
Covered Lines:	2315
Relevant Lines:	9047

💛 - Coveralls

github-actions · 2023-10-18T23:16:43Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

SchSeba · 2023-10-19T00:05:02Z

The retry on the resource creation make it

2023/10/19 00:00:46 http: TLS handshake error from 10.132.0.9:51698: remote error: tls: bad certificate
2023/10/19 00:00:47 http: TLS handshake error from 10.132.0.9:51714: remote error: tls: bad certificate
2023/10/19 00:00:49 http: TLS handshake error from 10.132.0.9:51728: remote error: tls: bad certificate
I1019 00:02:59.949878       1 start.go:70] handling request: {"kind":"AdmissionReview","apiVersion":"admission.k8s.io/v1","request":{"uid":"b740b3e8-90be-4826-8cfb-4a78d813a230","kind":{"group":"sriovnetwork.openshift.io","version":"v1","kind":"SriovNetworkNodePolicy"},"resource":{"group":"sriovnetwork.openshift.io","version":"v1","resource":"sriovnetworknodepolicies"},"requestKind":{"group":"sriovnetwork.openshift.io","version":"v1","kind":"SriovNetworkNodePolicy"},"requestResource":{"group":"sriovnetwork.openshift.io","version":"v1","resource":"sriovnetworknodepolicies"},"name":"test-policysnnrt","namespace":"openshift-sriov-network-operator","operation":"DELETE","userInfo":{"username":"system:admin","groups":["system:masters","system:authenticated"]},"object":null,"oldObject":{"apiVersion":"sriovnetwork.openshift.io/v1","kind":"SriovNetworkNodePolicy","metadata":{"creationTimestamp":"2023-10-19T00:00:44Z","generateName":"test-policy","generation":1,"managedFields":[{"apiVersion":"sriovnetwork.openshift.io/v1","fieldsType":"FieldsV1","fieldsV1":{"f:metadata":{"f:generateName":{}},"f:spec":{".":{},"f:deviceType":{},"f:nicSelector":{".":{},"f:pfNames":{}},"f:nodeSelector":{".":{},"f:kubernetes.io/hostname":{}},"f:numVfs":{},"f:priority":{},"f:resourceName":{}}},"manager":"conformance.test","operation":"Update","time":"2023-10-19T00:00:44Z"}],"name":"test-policysnnrt","namespace":"openshift-sriov-network-operator","resourceVersion":"24318","uid":"f84c44f2-2ec1-4c6b-9626-72727ca6cab6"},"spec":{"deviceType":"netdevice","isRdma":false,"nicSelector":{"pfNames":["enp22s0"]},"nodeSelector":{"kubernetes.io/hostname":"ocp-runner-1-worker-0.lab"},"numVfs":5,"priority":99,"resourceName":"testresource"}},"dryRun":false,"options":{"kind":"DeleteOptions","apiVersion":"meta.k8s.io/v1"}}}

looks like OCP refresh certificates and it take a few seconds for the new secret to be mounted and reloaded in the webhook pod

github-actions · 2023-10-19T03:54:00Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

SchSeba · 2023-10-19T03:54:10Z

@e0ne @zeeke please take a look

github-actions · 2023-10-19T05:06:49Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

.github/workflows/test.yml

github-actions · 2023-10-19T13:40:38Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-10-19T14:37:57Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke

LGTM

github-actions · 2023-10-20T11:45:38Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke · 2023-10-20T16:51:43Z

This fix will be useful to be sure we have no regression with:

Drain controller #488

github-actions · 2023-10-21T15:40:53Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-10-21T15:43:36Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

hack/run-e2e-conformance-virtual-cluster.sh

hack/run-e2e-conformance-virtual-ocp.sh

Updates to OCP: * add a retry to the policy create to fix OCP CI flake * add more ram to the OCP master single node * add a wait for registry to be available * update the ocp version to latest 4.14 rc release Updates for K8s: * switch to not use dockerhub for the registry image to overcome the pull limit * add alias for golang to the dockerhub image github actions: * always remove the cluster Signed-off-by: Sebastian Sch <sebassch@gmail.com>

github-actions · 2023-10-22T08:41:11Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

SchSeba · 2023-10-22T13:59:54Z

two approve merging

SchSeba force-pushed the update_ocp_ci_version branch from ae3bc49 to 390bded Compare October 18, 2023 23:16

SchSeba force-pushed the update_ocp_ci_version branch from 390bded to db39e3c Compare October 19, 2023 03:53

SchSeba changed the title ~~bump ocp version for CI~~ Add e2e test policy creation retry Oct 19, 2023

SchSeba force-pushed the update_ocp_ci_version branch from db39e3c to 8765f7f Compare October 19, 2023 05:06

bn222 reviewed Oct 19, 2023

View reviewed changes

.github/workflows/test.yml Show resolved Hide resolved

SchSeba force-pushed the update_ocp_ci_version branch from 8765f7f to 1bacb59 Compare October 19, 2023 13:40

SchSeba force-pushed the update_ocp_ci_version branch from 1bacb59 to ac612e8 Compare October 19, 2023 14:37

zeeke approved these changes Oct 20, 2023

View reviewed changes

SchSeba force-pushed the update_ocp_ci_version branch from ac612e8 to d50825d Compare October 20, 2023 11:45

SchSeba force-pushed the update_ocp_ci_version branch from d50825d to f8ca14f Compare October 21, 2023 15:40

SchSeba changed the title ~~Add e2e test policy creation retry~~ CI scripts improvements Oct 21, 2023

SchSeba force-pushed the update_ocp_ci_version branch from f8ca14f to 4847524 Compare October 21, 2023 15:43

adrianchiris approved these changes Oct 22, 2023

View reviewed changes

hack/run-e2e-conformance-virtual-cluster.sh Show resolved Hide resolved

hack/run-e2e-conformance-virtual-ocp.sh Show resolved Hide resolved

SchSeba force-pushed the update_ocp_ci_version branch from 4847524 to 6f54e23 Compare October 22, 2023 08:41

SchSeba merged commit 10a8201 into k8snetworkplumbingwg:master Oct 22, 2023
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI scripts improvements #523

CI scripts improvements #523

SchSeba commented Oct 18, 2023 •

edited

Loading

github-actions bot commented Oct 18, 2023

coveralls commented Oct 18, 2023 •

edited

Loading

github-actions bot commented Oct 18, 2023

SchSeba commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

SchSeba commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

zeeke left a comment

github-actions bot commented Oct 20, 2023

zeeke commented Oct 20, 2023

github-actions bot commented Oct 21, 2023

github-actions bot commented Oct 21, 2023

github-actions bot commented Oct 22, 2023

SchSeba commented Oct 22, 2023

CI scripts improvements #523

CI scripts improvements #523

Conversation

SchSeba commented Oct 18, 2023 • edited Loading

github-actions bot commented Oct 18, 2023

coveralls commented Oct 18, 2023 • edited Loading

Pull Request Test Coverage Report for Build 6602752479

💛 - Coveralls

github-actions bot commented Oct 18, 2023

SchSeba commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

SchSeba commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

zeeke left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 20, 2023

zeeke commented Oct 20, 2023

github-actions bot commented Oct 21, 2023

github-actions bot commented Oct 21, 2023

github-actions bot commented Oct 22, 2023

SchSeba commented Oct 22, 2023

SchSeba commented Oct 18, 2023 •

edited

Loading

coveralls commented Oct 18, 2023 •

edited

Loading