-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore nil objects occured when rendering a file #560
Ignore nil objects occured when rendering a file #560
Conversation
Thanks for your PR,
To skip the vendors CIs use one of:
|
This commits addresses an edge case where a nil object can occur while rendering a file. In that situation, in one of the places the renderer is used, it will try to add ownership to a nil object and fail. Signed-off-by: Vasilis Remmas <vremmas@nvidia.com>
4b45b6c
to
1822145
Compare
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 7219210136
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: The problem this PR fixes occurs even without the dash (-
):
i.e.:
{{ if .Enable }}
---
...
as the problem is related to the \n
before ---
, which ends up in a nil unstructured object.
BTW, the fix would remain the same. thanks for tackling this.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This commits addresses an edge case where a nil object can occur while rendering a file. In that situation, in one of the places the renderer is used, it will try to add ownership to a nil object and fail.
Testing
Before: