Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix number of args passed to log.Info #562

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Fix number of args passed to log.Info #562

merged 1 commit into from
Dec 20, 2023

Conversation

mandre
Copy link
Contributor

@mandre mandre commented Dec 19, 2023

This fix a crash:

DPANIC	sriovnetwork	webhook/validate.go:446	odd number of arguments passed as key-value pairs for logging	{"ignored key": "10ed"}

@mandre
Fix number of args passed to log.Info
29fb02b 
This fix a crash:
```
DPANIC	sriovnetwork	webhook/validate.go:446	odd number of arguments passed as key-value pairs for logging	{"ignored key": "10ed"}
```
@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7265525915

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.706%
Changes Missing Coverage Covered Lines Changed/Added Lines %
api/v1/helper.go 0 1 0.0%
Totals Coverage Status
Change from base Build 7239497185: 0.0%
Covered Lines: 2359
Relevant Lines: 9177
💛 - Coveralls

zeeke
zeeke approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks for fixing this

@mlguerrero12
Copy link
Contributor

LGTM

SchSeba
SchSeba approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianchiris adrianchiris merged commit dcd1a55 into k8snetworkplumbingwg:master Dec 20, 2023
11 checks passed
@mandre mandre deleted the fix-log-kv branch January 16, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeeke zeeke zeeke approved these changes

@SchSeba SchSeba SchSeba approved these changes

@adrianchiris adrianchiris adrianchiris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mandre @coveralls @mlguerrero12 @zeeke @SchSeba @adrianchiris