[switchdev 1/x] Add additional methods to host/kernel.go #582

ykulazhenkov · 2024-01-10T13:23:23Z

New methods are:

BindDriverByBusAndDevice - binds device to the provided driver
UnbindDriverByBusAndDevice unbind device identified by bus and device ID from the driver

Both methods allows to work with devices not
only on PCI bus.

+refactor driver-related methods
+add unit-tests for changed methods

Context:

part of switchdev refactoring
these changes are required to configure drivers for VDPA devices. VDPA device are on /sys/bus/vdpa, not on /sys/bus/pci

github-actions · 2024-01-10T13:23:35Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-01-10T13:25:29Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-01-10T13:27:12Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-01-10T13:27:49Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-01-10T13:32:38Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls · 2024-01-10T13:38:32Z

Pull Request Test Coverage Report for Build 7554932805

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.0%) to 24.354%

Totals
Change from base Build 7542427089:	1.0%
Covered Lines:	2422
Relevant Lines:	9945

💛 - Coveralls

ykulazhenkov · 2024-01-10T14:07:35Z

@adrianchiris @SchSeba PTAL

github-actions · 2024-01-11T09:44:25Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-01-12T14:02:38Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-01-12T14:18:05Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-01-12T14:30:01Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

ykulazhenkov · 2024-01-15T07:13:14Z

/test-all

github-actions · 2024-01-15T07:16:29Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke

Left a few minor comments.
I'm happy to see unit tests around driver logic, great work!

I personally prefer using literals instead of constants in test code, but I see it's debatable. Just saying that to see if any other has the same preference.

pkg/host/suite_test.go

pkg/host/kernel_test.go

github-actions · 2024-01-15T10:13:41Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

ykulazhenkov · 2024-01-15T10:18:33Z

I personally prefer using literals instead of constants in test code, but I see it's debatable. Just saying that to see if any other has the same preference.

Thanks for the review @zeeke

I thought about your point, and I agree that it is better to use string literals in this case. It is much easier to understand what the test does in this case. I already updated the PR.

zeeke

LGTM

adrianchiris

minor comments otherwise LGTM

pkg/consts/constants.go

pkg/host/kernel.go

New methods are: * BindDriverByBusAndDevice - binds device to the provided driver * UnbindDriverByBusAndDevice unbind device identified by bus and device ID from the driver Both methods allows to work with devices not only on PCI bus. +refactor driver-related methods +add unit-tests for changed methods Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>

github-actions · 2024-01-17T10:01:34Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-01-17T11:18:52Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

adrianchiris · 2024-01-17T11:53:04Z

LGTM, will merge once CI is green.

ykulazhenkov force-pushed the refactor-host-kernel branch from 2f1b7ad to aff61b4 Compare January 10, 2024 13:25

ykulazhenkov force-pushed the refactor-host-kernel branch from aff61b4 to 7dcdee6 Compare January 10, 2024 13:27

ykulazhenkov force-pushed the refactor-host-kernel branch from 7dcdee6 to 292811f Compare January 10, 2024 13:27

ykulazhenkov force-pushed the refactor-host-kernel branch from 292811f to 00fac27 Compare January 10, 2024 13:32

ykulazhenkov force-pushed the refactor-host-kernel branch from 00fac27 to 7d2da0f Compare January 11, 2024 09:44

ykulazhenkov mentioned this pull request Jan 11, 2024

[switchdev 3/x] Add host.VdpaInterface whch provided helpers to work with VDPA devices #585

Closed

ykulazhenkov changed the title ~~Add additional methods to host/kernel.go~~ [switchdev 1/x] Add additional methods to host/kernel.go Jan 12, 2024

ykulazhenkov force-pushed the refactor-host-kernel branch from 7d2da0f to 4c2f557 Compare January 12, 2024 14:02

ykulazhenkov force-pushed the refactor-host-kernel branch from 4c2f557 to e85ea1e Compare January 12, 2024 14:17

ykulazhenkov force-pushed the refactor-host-kernel branch from e85ea1e to 67415cc Compare January 12, 2024 14:29

ykulazhenkov closed this Jan 15, 2024

ykulazhenkov reopened this Jan 15, 2024

zeeke reviewed Jan 15, 2024

View reviewed changes

pkg/host/suite_test.go Outdated Show resolved Hide resolved

pkg/host/kernel_test.go Show resolved Hide resolved

pkg/host/kernel_test.go Outdated Show resolved Hide resolved

ykulazhenkov force-pushed the refactor-host-kernel branch from 67415cc to 25bb9f7 Compare January 15, 2024 10:13

zeeke approved these changes Jan 15, 2024

View reviewed changes

adrianchiris reviewed Jan 17, 2024

View reviewed changes

pkg/consts/constants.go Show resolved Hide resolved

pkg/host/kernel.go Outdated Show resolved Hide resolved

ykulazhenkov force-pushed the refactor-host-kernel branch from 25bb9f7 to 12e3306 Compare January 17, 2024 10:01

ykulazhenkov closed this Jan 17, 2024

ykulazhenkov reopened this Jan 17, 2024

adrianchiris approved these changes Jan 17, 2024

View reviewed changes

zeeke merged commit 09c987a into k8snetworkplumbingwg:master Jan 17, 2024
20 of 21 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[switchdev 1/x] Add additional methods to host/kernel.go #582

[switchdev 1/x] Add additional methods to host/kernel.go #582

ykulazhenkov commented Jan 10, 2024 •

edited

Loading

github-actions bot commented Jan 10, 2024

github-actions bot commented Jan 10, 2024

github-actions bot commented Jan 10, 2024

github-actions bot commented Jan 10, 2024

github-actions bot commented Jan 10, 2024

coveralls commented Jan 10, 2024 •

edited

Loading

ykulazhenkov commented Jan 10, 2024

github-actions bot commented Jan 11, 2024

github-actions bot commented Jan 12, 2024

github-actions bot commented Jan 12, 2024

github-actions bot commented Jan 12, 2024

ykulazhenkov commented Jan 15, 2024

github-actions bot commented Jan 15, 2024

zeeke left a comment

github-actions bot commented Jan 15, 2024

ykulazhenkov commented Jan 15, 2024

zeeke left a comment

adrianchiris left a comment

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

adrianchiris commented Jan 17, 2024

[switchdev 1/x] Add additional methods to host/kernel.go #582

[switchdev 1/x] Add additional methods to host/kernel.go #582

Conversation

ykulazhenkov commented Jan 10, 2024 • edited Loading

github-actions bot commented Jan 10, 2024

github-actions bot commented Jan 10, 2024

github-actions bot commented Jan 10, 2024

github-actions bot commented Jan 10, 2024

github-actions bot commented Jan 10, 2024

coveralls commented Jan 10, 2024 • edited Loading

Pull Request Test Coverage Report for Build 7554932805

💛 - Coveralls

ykulazhenkov commented Jan 10, 2024

github-actions bot commented Jan 11, 2024

github-actions bot commented Jan 12, 2024

github-actions bot commented Jan 12, 2024

github-actions bot commented Jan 12, 2024

ykulazhenkov commented Jan 15, 2024

github-actions bot commented Jan 15, 2024

zeeke left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 15, 2024

ykulazhenkov commented Jan 15, 2024

zeeke left a comment

Choose a reason for hiding this comment

adrianchiris left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

adrianchiris commented Jan 17, 2024

ykulazhenkov commented Jan 10, 2024 •

edited

Loading

coveralls commented Jan 10, 2024 •

edited

Loading