[switchdev 4/x] split systemd service to two parts #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
ykulazhenkov
commented
Jan 30, 2024
| Description=Configures SRIOV NIC - pre network configuration | ||
| DefaultDependencies=no | ||
| After=network-pre.target systemd-udev-settle.service systemd-sysusers.service systemd-sysctl.service | ||
| Before=network.target NetworkManager.service systemd-networkd.service ovs-vswitchd.service ovsdb-server.service |
There was a problem hiding this comment.
Note: If a service defined in After or Before section is not exist it will be simply ignored.
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
ykulazhenkov
force-pushed
the
pr-split-systemd-service
branch
from
ca39739
to
6da8431
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
ykulazhenkov
force-pushed
the
pr-split-systemd-service
branch
from
6da8431
to
e3fd1c8
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 7842844986
💛 - Coveralls |
ykulazhenkov
force-pushed
the
pr-split-systemd-service
branch
from
e3fd1c8
to
67155e3
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
ykulazhenkov
force-pushed
the
pr-split-systemd-service
branch
from
67155e3
to
00c277e
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
ykulazhenkov
force-pushed
the
pr-split-systemd-service
branch
from
00c277e
to
67f69ff
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
ykulazhenkov
force-pushed
the
pr-split-systemd-service
branch
from
67f69ff
to
7e39e9b
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
PR updated to add tests for systemd service |
ykulazhenkov
force-pushed
the
pr-split-systemd-service
branch
from
7e39e9b
to
9884bbc
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
adrianchiris
reviewed
Feb 7, 2024
zeeke
reviewed
Feb 8, 2024
There was a problem hiding this comment.
Left a few comments. I'm finding a little bit difficult to read the service.go file with that phase variable read in many places.
Have you considered the option of creating two functions runServiceCmdPre() and runServiceCmdPost() called at the very beginning of runServiceCmd()? That way we have a bunch of duplicated code, but we'd get rid of many if/else statments. WDYT?
bindata/manifests/sriov-config-service/kubernetes/sriov-config-service.yaml
Outdated
Show resolved
Hide resolved
The service has required argument "phase" Two phases are supported now: * pre - before the NetworkManager or systemd-networkd * post - after the NetworkManager or systemd-networkd "sriov-config" systemd unit is responsible for starting the service in the "pre" phase mode. "sriov-config-post-network" systemd unit starts the service in the "post" phase mode. The service may use different plugins for each phase and call different initialization flows. The "post" phase checks the completion status of the "pre" phase by reading the sriov result file. The "pre" phase should set "InProgress" status if it succeeds or "Failed" otherwise. If the result of the "pre" phase is different than "InProgress", then the "post" phase will not be executed and the execution result will be forcefully set to "Failed". Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
The first part is executed before the NeworkManager or systemd-networkd starts on the host. The second part is triggered after the network configuration is complete. This change is required to support hw offload use-case with systemd service. Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
ykulazhenkov
force-pushed
the
pr-split-systemd-service
branch
from
9884bbc
to
7faea56
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Thanks for the review @zeeke. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split systemd service to two parts:
The first part is executed before the
NeworkManager or systemd-networkd
starts on the host.
The second part is triggered after the
network configuration is complete.
This change is required to support hw offload
use-case with systemd service.
cc @adrianchiris @zeeke @SchSeba