Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Fix Debug logging should be visible in multus pod flake #611

Merged

Commits on Feb 2, 2024

  1. e2e: Fix Debug logging should be visible in multus pod flake

    Once the SriovNetwork has been created, test routine must wait for NetAttachDefinition
    to be created by the operator before spawing pods. Create a function `waitForNetAttachDef(...)`
    and use it in similar situations.
    
    The flake error this commit is supposed to fix is:
    ```
    • [FAILED] [2.695 seconds]
    [sriov] operator Generic SriovNetworkNodePolicy CNI Logging level [It] Debug logging should be visible in multus pod
    /root/opr-k8s-1/data/sriov-network-operator/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1077
    
      [FAILED] Unexpected error:
          <*errors.StatusError | 0xc000fd8640>:
          admission webhook "network-resources-injector-config.k8s.io" denied the request: could not find network attachment definition 'sriov-conformance-testing/test-log-level-debug-no-file': could not get Network Attachment Definition sriov-conformance-testing/test-log-level-debug-no-file: the server could not find the requested resource
          {
              ErrStatus: {
                  TypeMeta: {Kind: "", APIVersion: ""},
                  ListMeta: {
                      SelfLink: "",
                      ResourceVersion: "",
                      Continue: "",
                      RemainingItemCount: nil,
                  },
                  Status: "Failure",
                  Message: "admission webhook \"network-resources-injector-config.k8s.io\" denied the request: could not find network attachment definition 'sriov-conformance-testing/test-log-level-debug-no-file': could not get Network Attachment Definition sriov-conformance-testing/test-log-level-debug-no-file: the server could not find the requested resource",
                  Reason: "",
                  Details: nil,
                  Code: 400,
              },
          }
      occurred
      In [It] at: /root/opr-k8s-1/data/sriov-network-operator/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:2505 @ 02/01/24 12:44:25.702
    ```
    
    Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
    zeeke committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    20c08f5 View commit details
    Browse the repository at this point in the history