Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor improvements in sriovOpeatorConfig controller #618

Merged
merged 1 commit into from
Feb 6, 2024
Merged

minor improvements in sriovOpeatorConfig controller #618

merged 1 commit into from
Feb 6, 2024

Conversation

adrianchiris
Copy link
Collaborator

  • move log level handling earlier in reconcile flow
  • add log msg when reconicle has completed successfully

@adrianchiris
minor improvements in sriovOpeatorConfig controller
a0d9132 
- move log level handling earlier in reconcile flow
- add log msg when reconicle has completed successfully

Signed-off-by: adrianc <adrianc@nvidia.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7786222302

  • 0 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 25.838%
Files with Coverage Reduction New Missed Lines %
api/v1/helper.go 3 42.68%
Totals Coverage Status
Change from base Build 7784113078: -0.02%
Covered Lines: 2905
Relevant Lines: 11243
💛 - Coveralls

zeeke
zeeke approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeeke zeeke merged commit 252c959 into k8snetworkplumbingwg:master Feb 6, 2024
11 checks passed
@adrianchiris adrianchiris deleted the minor-improvement-operator-config branch July 16, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeeke zeeke zeeke approved these changes

@ykulazhenkov ykulazhenkov ykulazhenkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrianchiris @coveralls @zeeke @ykulazhenkov