Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indentation for --parallel-nic-config flag in the daemon manifest #637

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Fix indentation for --parallel-nic-config flag in the daemon manifest #637

merged 1 commit into from
Feb 16, 2024

Conversation

ykulazhenkov
Copy link
Collaborator

Fix indentation for --parallel-nic-config flag in the daemon manifest.
Without the fix template produces invalid YAML if parallelNicConfig feature gate is enabled.

cc @e0ne

@ykulazhenkov
Fix indentation for parallel-nic-config flag
2e2cafc 
fix indentation for the --parallel-nic-config in
the manifest. Without the fix template
produces invalid yaml if ParallelNicConfig is
enabled

Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7929543174

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 29.888%
Totals Coverage Status
Change from base Build 7918604669: 0.0%
Covered Lines: 3551
Relevant Lines: 11881
💛 - Coveralls

@e0ne e0ne requested a review from zeeke February 16, 2024 11:34
zeeke
zeeke approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks for fixing this

@zeeke zeeke merged commit 51ee23e into k8snetworkplumbingwg:master Feb 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e0ne e0ne e0ne approved these changes

@zeeke zeeke zeeke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ykulazhenkov @coveralls @e0ne @zeeke