Add logic to deploy OVS-cni #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 8327339491Details
💛 - Coveralls |
ykulazhenkov
force-pushed
the
pr-deploy-ovs-cni
branch
from
26a6ca3
to
20dbcac
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
If OVS_CNI_IMAGE env variable is set to empty string, then deployment of the CNI will be skipped Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
ykulazhenkov
force-pushed
the
pr-deploy-ovs-cni
branch
from
20dbcac
to
4b3a309
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Eoghan1232
reviewed
Mar 25, 2024
| @@ -95,6 +95,7 @@ images: | |||
| sriovConfigDaemon: ghcr.io/k8snetworkplumbingwg/sriov-network-operator-config-daemon | |||
| sriovCni: ghcr.io/k8snetworkplumbingwg/sriov-cni | |||
| ibSriovCni: ghcr.io/k8snetworkplumbingwg/ib-sriov-cni | |||
| ovsCni: quay.io/kubevirt/ovs-cni-plugin | |||
There was a problem hiding this comment.
ghcr.io/k8snetworkplumbingwg/ovs-cni-plugin
could we migrate to host image here instead of quay?
There was a problem hiding this comment.
https://github.com/k8snetworkplumbingwg/ovs-cni
or am I mixing these up? this is the proj correct?
There was a problem hiding this comment.
@Eoghan1232
Yes, the repo is in k8snetworkplumbingwg, but it is managed by kubevirt CI. I didn't find ovs-cni image in github registry, I think it is only uploaded to kubevirt registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy OVS CNI with initi container of the sriov-config-daemon.
Helm values or OVS_CNI_IMAGE env variable can be used to configure the OVS-cni image.
If OVS_CNI_IMAGE env variable is set to empty string, then deployment of the CNI will be skipped
Part of #640