support switching resource injector webhook to Fail #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
Fixes: #649 |
Using MatchConditions in the mutating webhook allow us to only call the webhook for pods with annotation `k8s.v1.cni.cncf.io/networks` Adding this feature under a featureGate as the MatchConditions was introduced in newer k8s version (beta on 1.28) Signed-off-by: Sebastian Sch <sebassch@gmail.com>
SchSeba
force-pushed
the
block_resource_injector
branch
from
0bed0a9
to
56454db
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 8314843722Details
💛 - Coveralls |
|
@e0ne @ykulazhenkov @zeeke @Eoghan1232 when you have time please take a look |
Eoghan1232
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using MatchConditions in the mutating webhook allow us to only call the webhook for pods with annotation
k8s.v1.cni.cncf.io/networksAdding this feature under a featureGate as the MatchConditions was introduced in newer k8s version (beta on 1.28)