Fix root device overlapping #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 8646930999Details
💛 - Coveralls |
e0ne
reviewed
Apr 2, 2024
api/v1/helper.go
Outdated
| @@ -547,6 +547,19 @@ func ParsePFName(name string) (ifName string, rngSt, rngEnd int, err error) { | |||
| return | |||
| } | |||
|
|
|||
| // ParseRootDevice: partse the rootDevice with VF range | |||
SchSeba
force-pushed
the
fix_root_device_overlap
branch
from
8572034
to
2b8c7c9
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
reviewed
Apr 2, 2024
| @@ -481,7 +481,7 @@ func (p *SriovNetworkNodePolicy) generateVfGroup(iface *InterfaceExt) (*VfGroup, | |||
| var rngStart, rngEnd int | |||
| found := false | |||
| for _, selector := range p.Spec.NicSelector.PfNames { | |||
There was a problem hiding this comment.
Ranges are still defined on PfNames field only.
You can verify it by adding unit tests like a92b764 .
There was a problem hiding this comment.
you are right!
I think supporting rage in the root device will be much harder than I was expecting so I will first fix the webhook issue and than we can take to the community to talk about the range support for rootDevices.
let me update the PR
SchSeba
force-pushed
the
fix_root_device_overlap
branch
from
2b8c7c9
to
9e5c802
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
SchSeba
force-pushed
the
fix_root_device_overlap
branch
from
9e5c802
to
04dbdf5
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
|
Hi @e0ne @Eoghan1232 when you have time please take a look on this small PR |
Eoghan1232
approved these changes
Apr 13, 2024
|
Thanks for the review folks! merging this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.