Make OVS_CNI_IMAGE truly optional #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `hack/env.sh` script expected that `OVS_CNI_IMAGE` is set, and exited with an error when it was not. There is no good reason for erroring out on missing variable for an optional image. Instead, set the variable to empty string when it is unset. When `SKIP_VAR_SET` is set, the default for `OVS_CNI_IMAGE` remains a valid image.
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
mandre
force-pushed
the
optional-OCS_CNI_IMAGE
branch
from
495f797
to
aa1ba65
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 8722690509Details
💛 - Coveralls |
|
@ykulazhenkov any objections here? |
no, LGTM |
ykulazhenkov
approved these changes
Apr 18, 2024
e0ne
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hack/env.shscript expected thatOVS_CNI_IMAGEis set, and exited with an error when it was not. There is no good reason for erroring out on missing variable for an optional image. Instead, set the variable to empty string when it is unset.When
SKIP_VAR_SETis set, the default forOVS_CNI_IMAGEremains a valid image.