Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support adding or removing node #688

Merged
merged 1 commit into from
May 1, 2024
Merged

Support adding or removing node #688

merged 1 commit into from
May 1, 2024

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Apr 25, 2024

No description provided.

@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Apr 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8893846922

Details

  • 14 of 26 (53.85%) changed or added relevant lines in 2 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.009%) to 38.537%
Changes Missing Coverage Covered Lines Changed/Added Lines %
controllers/sriovnetworknodepolicy_controller.go 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
controllers/sriovnetworknodepolicy_controller.go 2 12.13%
controllers/drain_controller.go 8 68.39%
Totals Coverage Status
Change from base Build 8893830201: -0.009%
Covered Lines: 4863
Relevant Lines: 12619
💛 - Coveralls

ykulazhenkov
ykulazhenkov approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@ykulazhenkov ykulazhenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nit: please add some details to the commit message

zeeke
zeeke approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchSeba
Support adding or removing node
5be2adc 
Add Watch in sriovNetworkNodePolicy for adding and removing nodes.

With this change we will be able act faster when new nodes are added
to the cluster and not waiting for the reconcile loop requeue

Signed-off-by: Sebastian Sch <sebassch@gmail.com>
@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@SchSeba SchSeba merged commit 047114b into k8snetworkplumbingwg:master May 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeeke zeeke zeeke approved these changes

@ykulazhenkov ykulazhenkov ykulazhenkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SchSeba @coveralls @zeeke @ykulazhenkov