Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use helm values to expand the supported NICs #698

Merged
merged 1 commit into from
May 16, 2024

Conversation

manuelbuil
Copy link
Contributor

The supported-nic-ids ConfigMap is a whitelist that includes details of some NICs. However, the user might want to add other NICs to that list so that the sriov operator works in his env.

The only way to do it right now is deploying the sriov-operator, editing that configmap and then restarting some of the sriov-operator components so that the new config is consumed.

This PR adds a new way to do it which can be easily automated: use a values.yaml parameter in the helm chart to include extra NICs. We can add the extra NICs when installing the sriov-operator, thus not requiring to restart any of the components

Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented May 10, 2024

Pull Request Test Coverage Report for Build 9060118246

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 39.634%

Files with Coverage Reduction New Missed Lines %
controllers/drain_controller.go 4 67.1%
Totals Coverage Status
Change from base Build 8958656332: -0.03%
Covered Lines: 5007
Relevant Lines: 12633

💛 - Coveralls

@adrianchiris
Copy link
Collaborator

Hi,
can you add some info in the README of the chart ?

Signed-off-by: Manuel Buil <mbuil@suse.com>
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@manuelbuil
Copy link
Contributor Author

Hi, can you add some info in the README of the chart ?

Done!

Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeeke zeeke merged commit 00ce764 into k8snetworkplumbingwg:master May 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants