Use helm values to expand the supported NICs #698
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
supported-nic-ids
ConfigMap is a whitelist that includes details of some NICs. However, the user might want to add other NICs to that list so that the sriov operator works in his env.The only way to do it right now is deploying the sriov-operator, editing that configmap and then restarting some of the sriov-operator components so that the new config is consumed.
This PR adds a new way to do it which can be easily automated: use a values.yaml parameter in the helm chart to include extra NICs. We can add the extra NICs when installing the sriov-operator, thus not requiring to restart any of the components