Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to remove a sriovPool named default #748

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Jul 25, 2024

we allow any name for the pool policy

we allow any name for the pool policy

Signed-off-by: Sebastian Sch <sebassch@gmail.com>
Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10094530178

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 43.919%

Files with Coverage Reduction New Missed Lines %
controllers/generic_network_controller.go 5 74.53%
controllers/sriovnetworkpoolconfig_controller.go 6 63.7%
Totals Coverage Status
Change from base Build 10072193709: -0.03%
Covered Lines: 6518
Relevant Lines: 14841

💛 - Coveralls

Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adrianchiris adrianchiris merged commit 511b470 into k8snetworkplumbingwg:master Aug 4, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants