Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix virtual cluster redeploy script #752

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Fix virtual cluster redeploy script #752

merged 1 commit into from
Aug 19, 2024

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Jul 29, 2024

No description provided.

@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Jul 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10452475855

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 45.006%
Totals Coverage Status
Change from base Build 10354035877: 0.007%
Covered Lines: 6534
Relevant Lines: 14518
💛 - Coveralls

adrianchiris
adrianchiris reviewed Aug 7, 2024
View reviewed changes
hack/virtual-cluster-redeploy.sh Show resolved Hide resolved
hack/virtual-cluster-redeploy.sh Outdated Show resolved Hide resolved
adrianchiris
adrianchiris reviewed Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit otherwise LGTM

hack/deploy-operator-helm.sh Outdated Show resolved Hide resolved
@SchSeba SchSeba force-pushed the fix_virtual_cluster_script branch 4 times, most recently from 05470c5 to d23ac38 Compare August 12, 2024 12:04
@SchSeba SchSeba force-pushed the fix_virtual_cluster_script branch 4 times, most recently from e973002 to a881023 Compare August 19, 2024 11:27
@SchSeba
Fix virtual cluster redeploy script
77c9410 
create a common helm deploy script to use

Signed-off-by: Sebastian Sch <sebassch@gmail.com>
@adrianchiris adrianchiris merged commit d4fcd5a into k8snetworkplumbingwg:master Aug 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeeke zeeke zeeke approved these changes

@adrianchiris adrianchiris adrianchiris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SchSeba @coveralls @zeeke @adrianchiris