Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security: Reduce rbac from webhooks #768

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Security: Reduce rbac from webhooks #768

merged 2 commits into from
Sep 3, 2024

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Aug 28, 2024

Always good to improve security

@SchSeba
security: remove not needed rbac rules from resource injector
c1f0f05 
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Aug 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10598926798

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 44.981%
Files with Coverage Reduction New Missed Lines %
controllers/drain_controller.go 1 68.06%
controllers/generic_network_controller.go 5 74.53%
Totals Coverage Status
Change from base Build 10594418576: -0.04%
Covered Lines: 6600
Relevant Lines: 14673
💛 - Coveralls

@SchSeba
security: remove not needed rbac rules from operator webhook
14e1bb8 
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
@SchSeba SchSeba force-pushed the reduce_rbac_resource_injector branch from 83fa0fb to 14e1bb8 Compare August 28, 2024 14:38
zeeke
zeeke approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're drastically reducing the attack surface here!

LGTM

@adrianchiris adrianchiris merged commit c5b82f3 into k8snetworkplumbingwg:master Sep 3, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeeke zeeke zeeke approved these changes

@adrianchiris adrianchiris adrianchiris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SchSeba @coveralls @zeeke @adrianchiris