Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: Fix NodeSelector with boolean values #770

Merged
merged 1 commit into from
Sep 6, 2024

Commits on Aug 29, 2024

  1. metrics: Fix NodeSelector with boolean values

    When using a node selector with boolean values, e.g.:
    ```
    apiVersion: sriovnetwork.openshift.io/v1
    kind: SriovOperatorConfig
    metadata:
      name: default
    spec:
      configDaemonNodeSelector:
        feature.node.kubernetes.io/network-sriov.capable: "true"
    ```
    
    the value needs to be quoted before forwarding it to the metrics-exporter
    node selector field.
    
    Fixes k8snetworkplumbingwg#766
    
    Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
    zeeke committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    c4572d7 View commit details
    Browse the repository at this point in the history