Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace nodeSelector with nodeAffinity master role #91

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Replace nodeSelector with nodeAffinity master role #91

merged 1 commit into from
Jun 15, 2021

Conversation

jcaamano
Copy link
Contributor

Label node-role.kubernetes.io/master has traditionally no value
associated inherited from kubeadm deplyments but some platforms use
"true" as value. Use node affinity instead of node selector ignoring the
value of the label.

@zshi-redhat
Copy link
Collaborator

do we have the same issue for node-role.kubernetes.io/worker ?

@jcaamano
Copy link
Contributor Author

jcaamano commented Apr 7, 2021

do we have the same issue for node-role.kubernetes.io/worker ?

No to the same extent. node-role.kubernetes.io/worker label is not standard, kubeadm does not set it for example. I guess openshift does. But it is being replaced by nodeselector from node policies and/or operator config so not really effective.

@zshi-redhat
Copy link
Collaborator

It might be good to do the same change for webhooks (webhook and operator-webhook) which run on master nodes (although they are not supported to run on k8s yet).

@zshi-redhat
Copy link
Collaborator

do we have the same issue for node-role.kubernetes.io/worker ?

No to the same extent. node-role.kubernetes.io/worker label is not standard, kubeadm does not set it for example. I guess openshift does. But it is being replaced by nodeselector from node policies and/or operator config so not really effective.

ack+

@zshi-redhat
Copy link
Collaborator

/cc @pliurh @SchSeba

@github-actions github-actions bot requested review from pliurh and SchSeba April 7, 2021 12:28
@jcaamano
Replace nodeSelector with nodeAffinity master role
de0891b 
Label node-role.kubernetes.io/master has traditionally no value
associated inherited from kubeadm deplyments but some platforms use
"true" as value. Use node affinity instead of node selector ignoring the
value of the label.
@jcaamano
Copy link
Contributor Author

jcaamano commented Apr 8, 2021

It might be good to do the same change for webhooks (webhook and operator-webhook) which run on master nodes (although they are not supported to run on k8s yet).

This is already included in this PR or am I missing something else?

@pliurh
Copy link
Collaborator

pliurh commented Apr 12, 2021

/lgtm

@github-actions github-actions bot added the lgtm label Apr 12, 2021
@jcaamano jcaamano mentioned this pull request Apr 22, 2021
Merged
e0ne
e0ne approved these changes May 31, 2021
View reviewed changes
Copy link
Collaborator

@e0ne e0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pliurh pliurh merged commit fc360d9 into k8snetworkplumbingwg:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pliurh pliurh pliurh left review comments

@e0ne e0ne e0ne approved these changes

@martinkennelly martinkennelly martinkennelly approved these changes

@SchSeba SchSeba Awaiting requested review from SchSeba

Assignees
No one assigned
Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jcaamano @zshi-redhat @pliurh @e0ne @SchSeba @martinkennelly