Diasble Oracle select-for-update for now

kagkarlsson · Aug 27, 2023 · 135c51b · 135c51b
1 parent 9991f0b
commit 135c51b
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/...heduler/src/main/java/com/github/kagkarlsson/scheduler/jdbc/MariaDBJdbcCustomization.java b/...heduler/src/main/java/com/github/kagkarlsson/scheduler/jdbc/MariaDBJdbcCustomization.java
@@ -29,7 +29,7 @@ public String getQueryLimitPart(int limit) {
 
   @Override
   public boolean supportsGenericLockAndFetch() {
-    // FIXLATER: enable for versions of MariaDB that supports it
+    // FIXLATER: fix syntax and enable it for versions of MariaDB that supports it
     return false;
   }
 

diff --git a/...cheduler/src/main/java/com/github/kagkarlsson/scheduler/jdbc/MySQL8JdbcCustomization.java b/...cheduler/src/main/java/com/github/kagkarlsson/scheduler/jdbc/MySQL8JdbcCustomization.java
@@ -29,7 +29,7 @@ public String getQueryLimitPart(int limit) {
 
   @Override
   public boolean supportsGenericLockAndFetch() {
-    // FIXLATER: enable when mysql-syntax fixed
+    // FIXLATER: fix syntax and enable
     return false;
   }
 

diff --git a/...cheduler/src/main/java/com/github/kagkarlsson/scheduler/jdbc/OracleJdbcCustomization.java b/...cheduler/src/main/java/com/github/kagkarlsson/scheduler/jdbc/OracleJdbcCustomization.java
@@ -24,7 +24,8 @@ public String getName() {
 
   @Override
   public boolean supportsGenericLockAndFetch() {
-    return true;
+    // FIXLATER: fix syntax and enable
+    return false;
   }
 
   @Override

diff --git a/...test/java/com/github/kagkarlsson/scheduler/compatibility/MariaDB103CompatibilityTest.java b/...test/java/com/github/kagkarlsson/scheduler/compatibility/MariaDB103CompatibilityTest.java
@@ -24,7 +24,7 @@ public class MariaDB103CompatibilityTest extends CompatibilityTest {
   private static HikariDataSource pooledDatasource;
 
   public MariaDB103CompatibilityTest() {
-    super(false);
+    super(false); // FIXLATER: fix syntax and enable
   }
 
   @BeforeAll

diff --git a/...src/test/java/com/github/kagkarlsson/scheduler/compatibility/Mysql8CompatibilityTest.java b/...src/test/java/com/github/kagkarlsson/scheduler/compatibility/Mysql8CompatibilityTest.java
@@ -23,9 +23,8 @@ public class Mysql8CompatibilityTest extends CompatibilityTest {
 
   private static HikariDataSource pooledDatasource;
 
-  // FIXLATER: enable select-for-update tests when SKIP LOCKED is fixed for mysql
   public Mysql8CompatibilityTest() {
-    super(false);
+    super(false); // FIXLATER: fix syntax and enable
   }
 
   @BeforeAll

diff --git a/.../test/java/com/github/kagkarlsson/scheduler/compatibility/Oracle11gCompatibilityTest.java b/.../test/java/com/github/kagkarlsson/scheduler/compatibility/Oracle11gCompatibilityTest.java
@@ -22,7 +22,7 @@ public class Oracle11gCompatibilityTest extends CompatibilityTest {
   private static HikariDataSource pooledDatasource;
 
   public Oracle11gCompatibilityTest() {
-    super(true);
+    super(false); // FIXLATER: fix syntax and enable
   }
 
   @BeforeAll