Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a maxRetriesExceededHandler to the MaxRetriesFailureHandler #397

Merged
merged 1 commit into from
Jun 17, 2023
Merged

feat: add a maxRetriesExceededHandler to the MaxRetriesFailureHandler #397

merged 1 commit into from
Jun 17, 2023

Conversation

piotrooo
Copy link
Contributor

Brief, plain english overview of your changes here

Discussion ref.: #394

Fixes

Closes #396

Reminders

  • Added/ran automated tests
  • Update README and/or examples
  • Ran mvn spotless:apply

cc @kagkarlsson

@piotrooo piotrooo changed the title Add a maxRetriesExceededHandler to the MaxRetriesFailureHandler feat: add a maxRetriesExceededHandler to the MaxRetriesFailureHandler Jun 1, 2023
@piotrooo
Copy link
Contributor Author

@kagkarlsson there is any chance to merge this and release version with this change?

Copy link
Owner

@kagkarlsson kagkarlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍

@@ -8,4 +8,4 @@ charset = utf-8

[*.java]
indent_style = space
indent_size = 4
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@kagkarlsson kagkarlsson merged commit 448d6d4 into kagkarlsson:master Jun 17, 2023
@piotrooo piotrooo deleted the feature/issue-396 branch June 18, 2023 14:25
@kagkarlsson kagkarlsson added the released Issue has been released label Jun 19, 2023
@kagkarlsson
Copy link
Owner

🎉 This issue has been resolved in v12.3.0 (Release Notes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Issue has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a maxRetriesExceededHandler to the MaxRetriesFailureHandler
2 participants