Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click event not sent in iframe API #153

Closed
claustres opened this issue Dec 23, 2020 · 2 comments
Closed

Click event not sent in iframe API #153

claustres opened this issue Dec 23, 2020 · 2 comments
Assignees
@claustres
Labels
bug Something isn't working
Milestone
v1.2.x

Comments

@claustres
Copy link
Member

post-robot complains about a circular structure to be serialized. Linked to the leaflet layer passed to post-robot instead of the layer definition object (see 0206e83#diff-cfa165427c75bcb64098dc8e3fd2f7862a579348ac088ddee2af048a185ba081R211).
@claustres claustres added the bug Something isn't working label Dec 23, 2020
@claustres claustres added this to the v1.2.0 milestone Dec 23, 2020
@claustres claustres self-assigned this Dec 23, 2020
@claustres
Copy link
Member Author

Fixed in 6735c9d.

@claustres claustres reopened this Jan 4, 2021
@claustres
Copy link
Member Author

The bug still appears if the layer contains a template definition.

It is related to the fact we process the input layer options here, possibly adding internal objects like template compilers, and the processed options are then sent with the event. We should instead send the original options, not the processed ones.

claustres added a commit that referenced this issue Jan 4, 2021
@claustres
fix: Click event not sent in iframe API (closes #153)
5d59ee2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claustres claustres

Labels
bug Something isn't working
Projects
Kano Roadmap
Status: Done
Milestone
v1.2.x
Development

No branches or pull requests
1 participant
@claustres