Merge bitcoin#17184: util: Filter out macOS process serial number

b5f0be3 util: Filter out macOS process serial number (Hennadii Stepanov)

Pull request description:

  Fix bitcoin#17179

ACKs for top commit:
  laanwj:
    ACK b5f0be3
  MarcoFalke:
    unsigned ACK b5f0be3
  promag:
    ACK b5f0be3.
  fanquake:
    ACK b5f0be3 - Tested that this fixes bitcoin#17179.

Tree-SHA512: 84ce859e53ebc7ad2d0a45e954243ef6efee640f1e0212322f68a317e4361a216ecb4b5a3a410ab31613adc285c8d3840fbf41fa9da9019be3d734db6b9427cd

src/util/system.cpp

@@ -379,6 +379,15 @@ bool ArgsManager::ParseParameters(int argc, const char* const argv[], std::strin
 
     for (int i = 1; i < argc; i++) {
         std::string key(argv[i]);
+
+#ifdef MAC_OSX
+        // At the first time when a user gets the "App downloaded from the
+        // internet" warning, and clicks the Open button, macOS passes
+        // a unique process serial number (PSN) as -psn_... command-line
+        // argument, which we filter out.
+        if (key.substr(0, 5) == "-psn_") continue;
+#endif
+
         if (key == "-") break; //bitcoin-tx using stdin
         std::string val;
         size_t is_index = key.find('=');