MBV Property Based Testing -- Do Not Merge #3

Adding rapidcheck dependency, adding CKey properties Successfully compiling bitcoin with rapidcheck dependency Adding new property file for CKey Serialization symmetry for CKey -> CBitcoinSecret -> CKey Adding generators for CPrivKey, CPubKey, and uint256 [depends] Rework rapidcheck.mk

Fixing generator bug where I wasn't setting all fields on a BlockHeader

…ization symmetry property for COutPoint

…pt serialization symmetry

… for CTransaction Removing 'oneOrMoreInputs' and 'oneOrMoreOutputs' generators in favor of using rapidcheck's gen::nonEmpty function

…ock serialization symmetry

…LoadedBloomFilter

Committing to try and debug mem leak Removing comments, rebasing to master Only adding rapidcheck dependency if tests are enabled Refactoring inclues in generator files, reordering files in Makefile.test.include Undoing change in merkleblock.cpp

…uchThat, removing some unused imports

…a generator called signedP2SHTx() that creates a p2sh output and spends it

…ences, fixing more nits

This adds new fields 'pubkeys' and 'embedded' to the RPC's output, and improves the documentation for previously added 'witness_version' and 'witness_program' fields.

Replaces numbered place marker %2 with %1, because the QString::arg() member function is called once on the string used to create the QString object.

Make CKeyStore automatically known about the redeemscripts necessary for P2SH-P2WPKH (and due to the extra checks in IsMine, also P2WPKH) spending.

This introduces two command line flags (-addresstype and -changetype) which control the type of addresses/outputs created by the GUI and RPCs. Certain RPCs allow overriding these (`getnewaddress` and `getrawchangeaddress`). Supported types are "legacy" (P2PKH and P2SH-multisig), "p2sh-segwit" (P2SH-P2WPKH and P2SH-P2WSH-multisig), and "bech32" (P2WPKH and P2WSH-multisig). A few utility functions are added to the wallet to construct different address type and to add the necessary entries to the wallet file to be compatible with earlier versions (see `CWallet::LearnRelatedScripts`, `GetDestinationForKey`, `GetAllDestinationsForKey`, `CWallet::AddAndGetDestinationForScript`).

Improvements and cleanups by John Newbery

… a SHA-256 run to be saved for future resumption, or in the case of fast Merkle trees to perform a non-padded hash.

…e initialization vectors allows SHA-256 to be reused as a different cryptographic hash function while sharing the same implementation, which is necessary to secure some hash tree protocols.

…to perform a single SHA-256 compression with a custom initialization vector per internal node of a binary Merkle tree, and is not vulnerable to CVE-2012-2459. It produces different hash values though, so can only be used for new hash trees going forward.

…mitting and validating proofs of multiple elements from a fast Merkle tree. The MerkleProof contains the tree structure and skip hashes, while the MerkleTree contains a proof and associated verify hashes.

[... leaf/H(leaf) ...] proof root {count,prehashed} MERKLEBRANCHVERIFY This opcode takes a Merkle root, any number of leaf hashes of the tree, and a 'proof' object composed of an encoding of the path through the tree from root to leaves and the minimal set of hash values necessary to recompute the the root from the leaf. Script validation fails if the recomputed root does not match the hash provided (which, presumably, would be committed to in the scriptPubKey). Only the logic and unit tests are implemented; this commit does not have any soft-fork activation logic in it. See BIP116 for details.

…nsactions that fail MBV verification will be rejected from the mempool, making it easier to test and to later soft-fork activate this feature. Blocks which contain "invalid" MBV-using transactions will still be accepted; this is *not* the soft-fork required to use MBV in production.

Creating merkle branch verify script and transaction generators

… leaf merkle tree

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MBV Property Based Testing -- Do Not Merge #3

MBV Property Based Testing -- Do Not Merge #3

Commits on Jan 12, 2018