Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tagMetric is not applied if the Span is not sampled #513

Closed
ivantopo opened this issue Feb 3, 2018 · 0 comments
Closed

tagMetric is not applied if the Span is not sampled #513

ivantopo opened this issue Feb 3, 2018 · 0 comments
Assignees
@ivantopo
Labels
Bug

Comments

@ivantopo
Copy link
Contributor

ivantopo commented Feb 3, 2018

Metric tags should always be applied, regardless of the Span being sampled or not. Reported by @lbarasti here: https://gitter.im/kamon-io/Kamon?at=5a748509a3447aac753220a3
@ivantopo ivantopo self-assigned this Feb 10, 2018
ivantopo added a commit that referenced this issue Feb 13, 2018
@ivantopo
Merge pull request #516 from ivantopo/issue#513/tagMetric-not-working…
26e8684 
…-on-unsampled-spans

apply metric tags on spans, even if the span is not sampled, fixes #513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivantopo ivantopo

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ivantopo