Preview emojis in chatbox #199
Conversation
|
Have you tested this with Rails assets precompiling? According to the gemoji gem you need to set it up on the application.rb file. Im not familiar with them gem but thats what i read on their page. |
|
Gemoji doesn't provide assets by default - rather you have to copy them into either public/ or app/assets/images/ or whatever manually. As we already (currently) have emojis in app/assets, I'm making use of the 'database' provided by Gemoji, but not using the images. I think we should consider using the Gemoji gem for providing the images too in future, but that's out of scope of this PR IMHO. |
|
Also note that without the refactoring of the emoticons the images provided by this gem will not be shown since plugin ares triggered in the order that they are added on the kandan file which means all emojis will be caught by the emoticons plugin. I am working on plugin chaining which will help with this but will cause worse things such as emojis shown twice (by the emoji plugin and the emoticons plugin) |
|
Your comment answered my previous comment 👍 |
|
This plugin only handles displaying the emojis as previews in the chatbox, so doesn't expect or interfere with the activity rendering right now. Refactoring the emojis plugin to handle the emojis should be done at the same time as removing that capability from the emoticons plugin, so there shouldn't be a case where they interfere with each other. |
ghost
assigned 
|
Done! Could you open an issue for refactoring emoticons and assign it to me. Im on my phone and Github iPhone experience is less than ideal. |
…eview Preview emojis in chatbox
Does what it says in the title. Adds a dependency on Gemoji. We should consider refactoring the emoticons plugin to revert it to dealing with emoticons other than emojis and move the emoji rendering to this plugin.