Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow for passing an empty argument to the option and will delegate the logic for managing the empty argument to the user side. See the full discussion here.
Now, we can call
command.NewOptionWithArgument("--opt", "")
, and it will generate--opt=
, which is a legitimate case. The previous implementation skipped generating--opt
if argument was an empty string (""
).This logic has now been transferred to the user side for handling empty arguments.