Skip to content

Commit

Permalink
Fix not identifying all Github token occurrences in a file Yelp#858
Browse files Browse the repository at this point in the history
  • Loading branch information
karamuz committed Jun 20, 2024
1 parent 10d13a8 commit 7c6a607
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions detect_secrets/plugins/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -165,13 +165,8 @@ def denylist(self) -> Iterable[Pattern]:

def analyze_string(self, string: str) -> Generator[str, None, None]:
for regex in self.denylist:
for match in regex.findall(string):
if isinstance(match, tuple):
for submatch in filter(bool, match):
# It might make sense to paste break after yielding
yield submatch
else:
yield match
for match in regex.finditer(string):
yield match.group(0) # Returns the entire matched string

@staticmethod
def build_assignment_regex(
Expand Down

0 comments on commit 7c6a607

Please sign in to comment.