Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Test Fail to Pass on Node 0.10 #447

Closed
ngiebel opened this issue Apr 1, 2013 · 0 comments
Closed

Unit Test Fail to Pass on Node 0.10 #447

ngiebel opened this issue Apr 1, 2013 · 0 comments

Comments

@ngiebel
Copy link

ngiebel commented Apr 1, 2013

There is a unit test that is failing currently due to the fact that typeof null is not 'string'. This was partially fixed with the commit a4ef866. I can create a fix for this but I am not sure if the fix should be that null never makes it to the function basePathResolve in config.js or if null should just be ignored in the same manner that undefined was in the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant