Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): improve public api #1485

Merged
merged 1 commit into from
Jul 13, 2015

Conversation

dignifiedquire
Copy link
Member

This adds a slew of new api possibilities to the server. All main
events
from the globalEmitter are now emitted on the server instances and
publicly available.
For a list of available events see the docs file.

BREAKING CHANGE:

The public api interface has changed to a constructor form. To upgrade
change

var server = require(‘karma’).server
server.start(config, done)

to

var Server = require(‘karma’).Server
var server = new Server(config, done)
server.start()

Closes #1037, #1482, #1467

This adds a slew of new api possibilities to the server. All main
events
from the `globalEmitter` are now emitted on the `server` instances and
publicly available.
For a list of available events see the docs file.

BREAKING CHANGE:

The public api interface has changed to a constructor form. To upgrade
change

```javascript
var server = require(‘karma’).server
server.start(config, done)
```

to

```javascript
var Server = require(‘karma’).Server
var server = new Server(config, done)
server.start()
```

Closes karma-runner#1037, karma-runner#1482, karma-runner#1467
@dignifiedquire
Copy link
Member Author

@zzo @maksimr @pkozlowski-opensource if you have some time, please take a look and let me know what you thinkg

@dignifiedquire dignifiedquire added this to the 0.13 milestone Jul 8, 2015
@zzo
Copy link
Contributor

zzo commented Jul 8, 2015

like it. Now would be the time to get in breaking changes.

dignifiedquire added a commit that referenced this pull request Jul 13, 2015
feat(server): improve public api
@dignifiedquire dignifiedquire merged commit e364149 into karma-runner:canary Jul 13, 2015
@dignifiedquire dignifiedquire deleted the server-api branch July 13, 2015 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants