Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add resource name #194

Closed
wants to merge 3 commits into from
Closed

fix: add resource name #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2607055
fix: add resource name
artaasadi Jun 7, 2024
7beb9f3
fix: add csv view for aws plugin
artaasadi Jun 11, 2024
8004270
fix: resolve conflicts
artaasadi Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/plugin/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,8 +276,8 @@ func (m *Manager) Install(addr, token string, unsafe, pluginDebugMode bool) erro
if p, ok := plugins[addr]; ok && p.Config.Version == assetVersion {
return nil
}
fmt.Printf("Installing plugin %s, version %s\n", addr, assetVersion)
fmt.Println("Downloading the plugin...")
os.Stderr.WriteString(fmt.Sprintf("Installing plugin %s, version %s\n", addr, assetVersion))
os.Stderr.WriteString("Downloading the plugin...\n")

rc, url, err := api.Repositories.DownloadReleaseAsset(context.Background(), owner, repository, *asset.ID, nil)
if err != nil {
Expand Down Expand Up @@ -325,7 +325,7 @@ func (m *Manager) Install(addr, token string, unsafe, pluginDebugMode bool) erro
Commands: nil,
},
}
fmt.Println("Starting the plugin...")
os.Stderr.WriteString("Starting the plugin...\n")
runningCmd, err := startPlugin(&plugin, fmt.Sprintf("localhost:%d", m.port))
if err != nil {
return err
Expand All @@ -335,7 +335,7 @@ func (m *Manager) Install(addr, token string, unsafe, pluginDebugMode bool) erro
m.plugins = nil
}()

fmt.Println("Waiting for plugin to load...")
os.Stderr.WriteString("Waiting for plugin to load...\n")
installed := false
for i := 0; i < 30; i++ {
for _, runningPlugin := range m.plugins {
Expand Down
5 changes: 5 additions & 0 deletions pkg/plugin/proto/plugin.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,10 @@ message ResultSummary {
string message = 1;
}

message ProfileDetail {
string account_id = 1;
}

message PluginMessage {
oneof plugin_message {
JobResult job = 1;
Expand All @@ -147,6 +151,7 @@ message PluginMessage {
ChartOptimizationItem coi = 6;
UpdateChartDefinition update_chart = 7;
ResultSummary summary = 8;
ProfileDetail profile = 9;
}
}

Expand Down
Loading