Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow colon in locale message keys used in linked locale messages #1488

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

ax-jmckenzie
Copy link
Contributor

@ax-jmckenzie ax-jmckenzie commented Mar 26, 2022

Linked Locale Messages break when the linked locale message key contains a : character. This updates a regex to allow for keys containing :, as long as the linked locale message uses the brackets syntax.

example:

{
  "homeAddress:phrase": "Home Address",
  "missingHomeAddress:validation": 'Please provide @.lower:(homeAddress:phrase)'
}

Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Could you add the unit test cases, please? 🙏
Our maintainers need to ensure that your updating works correctly.

@kazupon kazupon added the Type: Improvement Includes backwards-compatible fixes label Mar 27, 2022
@ax-jmckenzie
Copy link
Contributor Author

@kazupon, thanks for taking a look at this PR! I've added unit tests as requested.

@kazupon
Copy link
Owner

kazupon commented Mar 29, 2022

Thanks!
Good for your contribution! :)

@kazupon kazupon merged commit b3624fe into kazupon:v8.x Mar 29, 2022
@pr-triage pr-triage bot added the PR: merged label Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants