Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve directive content #495

Merged
merged 4 commits into from
Jan 2, 2019

Conversation

bponomarenko
Copy link
Contributor

This PR is fixing #408.

preserveDirectiveContent is false by default to remain backward compatibility. In the future (if there will be demand for it) it can be set to true by default, but that would be a breaking change.

Documentation is also updated in vuepress folder as it seems to contain actual docs.

@codecov-io
Copy link

Codecov Report

Merging #495 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #495      +/-   ##
==========================================
+ Coverage   96.69%   96.71%   +0.01%     
==========================================
  Files           9        9              
  Lines         666      670       +4     
==========================================
+ Hits          644      648       +4     
  Misses         22       22
Impacted Files Coverage Δ
src/mixin.js 96.66% <100%> (+0.05%) ⬆️
src/index.js 99.64% <100%> (ø) ⬆️
src/directive.js 92.98% <100%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa20962...2dd3c53. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Dec 29, 2018

Codecov Report

Merging #495 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #495      +/-   ##
==========================================
+ Coverage   96.69%   96.71%   +0.01%     
==========================================
  Files           9        9              
  Lines         666      670       +4     
==========================================
+ Hits          644      648       +4     
  Misses         22       22
Impacted Files Coverage Δ
src/mixin.js 96.66% <100%> (+0.05%) ⬆️
src/index.js 99.64% <100%> (ø) ⬆️
src/directive.js 92.98% <100%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa20962...2dd3c53. Read the comment docs.

@bponomarenko
Copy link
Contributor Author

Happy New Year @kazupon!
Does this PR make sense?

Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍
Thanks!

@kazupon kazupon merged commit c29edba into kazupon:dev Jan 2, 2019
@bponomarenko
Copy link
Contributor Author

Perfect! Thanks for merging.

@sirlancelot
Copy link

Thanks for this! 🎉 I understand making it false for backwards compatibility but I feel like true should be the default in a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants