Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#184] Updated importRecords Action to support Excel file import #188

Merged
merged 2 commits into from
Jul 21, 2024
Merged

[#184] Updated importRecords Action to support Excel file import #188

merged 2 commits into from
Jul 21, 2024

Conversation

palagdan
Copy link
Collaborator

Partially resolves #184

@palagdan
Copy link
Collaborator Author

palagdan commented Jul 19, 2024 •
edited
Loading

I added new path variables to handle specific file format:

  let apiUrl = `${API_URL}/rest/records/import`;
    if (fileExtension === "json") {
      apiUrl = `${API_URL}/rest/records/import/json`;
    } else if (["xls", "xlsx"].includes(fileExtension)) {
      apiUrl = `${API_URL}/rest/records/import/excel`;

Based on this updated request, I updated endpoint on backend:
kbss-cvut/record-manager@5e1719d

@palagdan palagdan requested review from blcham and LaChope July 19, 2024 09:38
@blcham
[#184] Implement detached import through TSV
4205dc2 
I.e. import that is fully implemented by external service. In this case database is modified by separate service.
@blcham blcham merged commit 43c02fe into main Jul 21, 2024
2 checks passed
@blcham blcham deleted the feature/184-support-import-from-excel branch July 21, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blcham blcham blcham approved these changes

@LaChope LaChope Awaiting requested review from LaChope

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support import records from excel file
2 participants
@palagdan @blcham