Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blurb about standalone CRDs #1191

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

atzawada
Copy link
Contributor

Relates to a future PR in kedacore/keda

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

@atzawada atzawada requested a review from a team as a code owner July 20, 2023 18:29
@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit e4658a2
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/64b9952d6d6ee50008455c32
😎 Deploy Preview https://deploy-preview-1191--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Signed-off-by: Andy Zawada <zawada1@nationwide.com>
@atzawada atzawada force-pushed the atzawada-add-standalone-crds branch from 777dce3 to 843d59c Compare July 20, 2023 18:40
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only v2.12 has to be updated because v2.10 and v2.11 won't have that option as they are already released. Could you revert changes in v2.10 and v2.11?

Signed-off-by: Andy Zawada <zawada1@nationwide.com>
@atzawada
Copy link
Contributor Author

Done! I thought 2.10 and 2.11 were still active release lines for some reason. Now it should only reflect the change for 2.12

@JorTurFer JorTurFer merged commit c54811c into kedacore:main Jul 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants