Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that autoscaling.keda.sh/paused annotation value is not important. Only prescence is checked #1266

Closed
wants to merge 2 commits into from

Conversation

nappelson
Copy link
Contributor

@nappelson nappelson commented Nov 27, 2023

Essentially, as a new Keda user I spent a long time trying to figure out why autoscaling.keda.sh/paused: false wasn't working as expected.

I opened this kedacore/keda#5215 in keda-core. Until a resolution is decided there, I think this documentation update would be beneficial to avoid end-user communication.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #
Potentially fixes - kedacore/keda#5215

…tant. Only prescence is checked

Signed-off-by: Nate Appelson <nappelson@gmail.com>
@nappelson nappelson requested a review from a team as a code owner November 27, 2023 20:26
Signed-off-by: nappelson <nappelson@gmail.com>
Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 8fda5b6
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6564fd53f6282a0008ab2593
😎 Deploy Preview https://deploy-preview-1266--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@tomkerkhove
Copy link
Member

Thanks! It is not important indeed, but I personally think the current example value still makes more sense though.

We can add the note you suggested, but I'd prefer to stick with true

@zroubalik
Copy link
Member

As discussed here, let's stay with true and add false once it is implemented.

kedacore/keda#5215

@tomkerkhove
Copy link
Member

Closing because of the above, but thanks for proposing anyway!

@tomkerkhove tomkerkhove closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants