Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Provide Azure Data Explorer Scaler #658

Merged
merged 8 commits into from
Mar 14, 2022

Conversation

yasiboni-max
Copy link
Contributor

@yasiboni-max yasiboni-max commented Feb 12, 2022

Signed-off-by: Yarden Siboni yardensib@gmail.com

This is the documentation for an Azure Data Explorer scaler. This is related to this issue:

kedacore/keda#1488

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #1488

@netlify
Copy link

netlify bot commented Feb 12, 2022

✔️ Deploy Preview for keda ready!

🔨 Explore the source changes: 7eb84b6

🔍 Inspect the deploy log: https://app.netlify.com/sites/keda/deploys/6215e9d0bfed02000749879b

😎 Browse the preview: https://deploy-preview-658--keda.netlify.app

@yasiboni-max yasiboni-max changed the title docs: Provide Azure Data Explorer Scaler (#1488) docs: Provide Azure Data Explorer Scaler Feb 12, 2022
Signed-off-by: Yarden Siboni <yasiboni@microsoft.com>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Just added editorial notes

content/docs/2.7/scalers/azure-data-explorer.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/azure-data-explorer.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/azure-data-explorer.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/azure-data-explorer.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/azure-data-explorer.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/azure-data-explorer.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/azure-data-explorer.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/azure-data-explorer.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/azure-data-explorer.md Outdated Show resolved Hide resolved
Signed-off-by: Yarden Siboni <yasiboni@microsoft.com>
Signed-off-by: Yarden Siboni <yasiboni@microsoft.com>
Signed-off-by: Yarden Siboni <yasiboni@microsoft.com>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few last alignments but LGTM for the rest

content/docs/2.7/scalers/azure-data-explorer.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/azure-data-explorer.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/azure-data-explorer.md Outdated Show resolved Hide resolved
Signed-off-by: Yarden Siboni <yasiboni@microsoft.com>
@yasiboni-max
Copy link
Contributor Author

Just a few last alignments but LGTM for the rest

Closed by mistake

@yasiboni-max yasiboni-max reopened this Feb 22, 2022
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

content/docs/2.7/scalers/azure-data-explorer.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/azure-data-explorer.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/azure-data-explorer.md Outdated Show resolved Hide resolved
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove tomkerkhove merged commit 16ccffd into kedacore:main Mar 14, 2022
samueleresca pushed a commit to samueleresca/keda-docs that referenced this pull request Mar 17, 2022
Co-authored-by: Yarden Siboni <yasiboni@microsoft.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants